Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port callback functions into hookset #209

Merged
merged 1 commit into from Jul 22, 2016
Merged

Conversation

@paltman
Copy link
Member

paltman commented Feb 18, 2016

Closes #106

Closes #106
@ossanna16
Copy link
Contributor

ossanna16 commented Feb 22, 2016

@brosner Can this be merged?

@brosner
Copy link
Member

brosner commented Jul 21, 2016

This PR raises the question of compatibility. This change is backward incompatible. Do we accept it and release 2.0? If so, what about support for 1.X? I suppose the answer to the latter question is depdent on the support of 16.04.

It would be possible to support both and release 1.4. Have the hookset call the old callbacks.

Thoughts?

@jtauber
Copy link
Member

jtauber commented Jul 21, 2016

I propose going ahead with this as @paltman proposed, with the backwards incompatibility. It's cleaner plus it gives us an opportunity to decide in 16.07 some of our policies and processes around BIs and how we document migrations between distribution releases, etc. This is a nice simple case to prove that out on.

@brosner brosner merged commit 21bfb85 into pinax:master Jul 22, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.