Port callback functions into hookset#209
Merged
brosner merged 1 commit intopinax:masterfrom Jul 22, 2016
Merged
Conversation
Contributor
|
@brosner Can this be merged? |
Member
|
This PR raises the question of compatibility. This change is backward incompatible. Do we accept it and release 2.0? If so, what about support for 1.X? I suppose the answer to the latter question is depdent on the support of 16.04. It would be possible to support both and release 1.4. Have the hookset call the old callbacks. Thoughts? |
Member
|
I propose going ahead with this as @paltman proposed, with the backwards incompatibility. It's cleaner plus it gives us an opportunity to decide in 16.07 some of our policies and processes around BIs and how we document migrations between distribution releases, etc. This is a nice simple case to prove that out on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106