Skip to content

Port callback functions into hookset#209

Merged
brosner merged 1 commit intopinax:masterfrom
paltman:callback-cleanup
Jul 22, 2016
Merged

Port callback functions into hookset#209
brosner merged 1 commit intopinax:masterfrom
paltman:callback-cleanup

Conversation

@paltman
Copy link
Contributor

@paltman paltman commented Feb 18, 2016

Closes #106

@ossanna16
Copy link
Contributor

@brosner Can this be merged?

@brosner
Copy link
Member

brosner commented Jul 21, 2016

This PR raises the question of compatibility. This change is backward incompatible. Do we accept it and release 2.0? If so, what about support for 1.X? I suppose the answer to the latter question is depdent on the support of 16.04.

It would be possible to support both and release 1.4. Have the hookset call the old callbacks.

Thoughts?

@jtauber
Copy link
Member

jtauber commented Jul 21, 2016

I propose going ahead with this as @paltman proposed, with the backwards incompatibility. It's cleaner plus it gives us an opportunity to decide in 16.07 some of our policies and processes around BIs and how we document migrations between distribution releases, etc. This is a nice simple case to prove that out on.

@brosner brosner merged commit 21bfb85 into pinax:master Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments