Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic settings in migrations to match model #217

Merged
merged 1 commit into from Jul 21, 2016

Conversation

@jpotterm
Copy link
Contributor

jpotterm commented May 10, 2016

Currently, if the user changes his ACCOUNT_LANGUAGES setting the Django migration autodetector will create new migrations inside of django-user-accounts because the value of Account.language.choices has changed. This pull request fixes that by also referencing settings within the migration.

This seems to be the best practice and is used by django-cms migrations and discussed in a Django ticket.

…Django migration autodetector from making new migrations when a user changes settings.
@coveralls
Copy link

coveralls commented May 10, 2016

Coverage Status

Coverage increased (+0.02%) to 68.124% when pulling fb82407 on jpotterm:migration_dynamic_language_settings into ca45e17 on pinax:master.

@brosner brosner merged commit e0aa538 into pinax:master Jul 21, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage increased (+0.02%) to 68.124%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.