Password expiration #223
Merged
Password expiration #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring common code into PasswordChangeMixin.
Update views to save password upon signup, change pw, or reset pw. Update LoginView to check for expired password. Added ACCOUNT_PASSWORD_USE_HISTORY (True/False) for determining whether or not to check password expiration. Added ACCOUNT_PASSWORD_EXPIRY (positive int) for number of seconds until password expires from last time it was set.
Add makemigrations.py.
|
@brosner can we get your feedback on this, pretty please? |
Add Django v1.10 to test matrix.
2 similar comments
|
LGTM. Going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds password expiration capability.
Adds password history.
Allows per-user setting of password expiration as well as global expiry value.
Permits disabling password history feature.
Permits specifying "no expiration".
Checks password expiration on each login. Does not check password expiration on each request.
Password history will allow password validation which enforces "cannot use old passwords" rule and other cases.
Needs tests.