Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password expiration #223

Merged
merged 7 commits into from Sep 9, 2016
Merged

Password expiration #223

merged 7 commits into from Sep 9, 2016

Conversation

@grahamu
Copy link
Contributor

grahamu commented Sep 2, 2016

Adds password expiration capability.
Adds password history.
Allows per-user setting of password expiration as well as global expiry value.
Permits disabling password history feature.
Permits specifying "no expiration".
Checks password expiration on each login. Does not check password expiration on each request.

Password history will allow password validation which enforces "cannot use old passwords" rule and other cases.

Needs tests.

grahamu added 4 commits Sep 1, 2016
Bring common code into PasswordChangeMixin.
Update views to save password upon signup, change pw, or reset pw.
Update LoginView to check for expired password.

Added ACCOUNT_PASSWORD_USE_HISTORY (True/False) for determining whether
or not to check password expiration.

Added ACCOUNT_PASSWORD_EXPIRY (positive int) for number of seconds until
password expires from last time it was set.
@coveralls
Copy link

coveralls commented Sep 2, 2016

Coverage Status

Coverage increased (+0.5%) to 68.46% when pulling 3635946 on password-expiration into b2691a6 on master.

Add makemigrations.py.
@paltman
Copy link
Member

paltman commented Sep 9, 2016

@brosner can we get your feedback on this, pretty please?

@coveralls
Copy link

coveralls commented Sep 9, 2016

Coverage Status

Coverage increased (+1.03%) to 68.984% when pulling a7a58eb on password-expiration into b2691a6 on master.

Add Django v1.10 to test matrix.
@coveralls
Copy link

coveralls commented Sep 9, 2016

Coverage Status

Coverage increased (+1.3%) to 69.283% when pulling 76ced62 on password-expiration into b2691a6 on master.

2 similar comments
@coveralls
Copy link

coveralls commented Sep 9, 2016

Coverage Status

Coverage increased (+1.3%) to 69.283% when pulling 76ced62 on password-expiration into b2691a6 on master.

@coveralls
Copy link

coveralls commented Sep 9, 2016

Coverage Status

Coverage increased (+1.3%) to 69.283% when pulling 76ced62 on password-expiration into b2691a6 on master.

@grahamu grahamu changed the title WIP - Password expiration Password expiration Sep 9, 2016
@brosner
Copy link
Member

brosner commented Sep 9, 2016

LGTM. Going to merge.

@brosner brosner merged commit 384476a into master Sep 9, 2016
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.3%) to 69.283%
Details
@brosner brosner deleted the password-expiration branch Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.