Correct the jQuery plugin loading order #9

Merged
merged 1 commit into from Jul 1, 2012

2 participants

@timheap

The phileo plugin was added to jQuery in the domready event callback. As
this plugin could be loaded at the bottom of a page - AFTER phileo
widget scripts - it was possible for the phileo plugin to not be
loaded when the widgets were initialized in the domready event. As the
phileo plugin does not need the DOM to be ready to set itself up, the
plugin now loads as the page is loading. This allows phileo widgets to
be inserted before the phileo plugin script and for everything to still
work.

Tim Heap Add jQuery plugin on page load, not domready
The phileo plugin was added to jQuery in the domready event callback. As
this plugin could be loaded at the bottom of a page - AFTER phileo
widget scripts - it was possible for the phileo plugin to not be
loaded when the widgets were initialized in the domready event. As the
phileo plugin does not need the DOM to be ready to set itself up, the
plugin now loads as the page is loading. This allows phileo widgets to
be inserted before the phileo plugin script and for everything to still
work.
388c801
@paltman paltman merged commit f9ac174 into pinax:master Jul 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment