Remove redundant transaction in customers.create #341
Conversation
|
Some context for this one, @paltman. I've been getting issues when using customer.create whereby the webhook It seems unlikely that the create Customer query would be uncommitted for a long enough period due transaction.atomic() such that the webhook arrives first, and yet I'm seeing this occur a few times per day. Any thoughts? I'd rather not preemptively create customers with Stripe. |
|
I'm trying to recall why I even had the transaction there in the first place. |
|
I'm good to merge this. Can you fix the lint issue first though, @lukeburden? |
lukeburden
force-pushed
the
remove-unnecessary-transaction
branch
2 times, most recently
from
fb5977f
to
7c486a1
Compare
|
So, I hit the reason why you added the transaction in the first place. Nasty, one that I've also hit in various projects. I've done some minor refactoring of the |
lukeburden
force-pushed
the
remove-unnecessary-transaction
branch
from
7c486a1
to
680a01f
Compare
|
Thanks! |
| if plan and charge_immediately: | ||
| invoices.create_and_pay(cus) | ||
| else: | ||
| # remove this extra customer as it is not needed | ||
| stripe.Customer.retrieve(stripe_customer["id"]).delete() |
There was a problem hiding this comment.
Wouldn't it be better to create it only in case there is no local customer already in the first pace?
There was a problem hiding this comment.
Yes, that would make sense. Go for it!
There was a problem hiding this comment.
Just for reference: finally rejected in #364.
The use of transaction.atomic() wrapping the Customer.objects.create call is redundant as there is only a single query which will either succeed or fail. If a customer already exists, an IntegrityError will still be raised.