Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of syncing deleted customers #357



Copy link

Credit to @tasn for work done in PR #325 - this PR adds tests

Fixes #268

What's this PR do?

Modifies deleted customer webhook to purge customer locally and not attempt to delete customer again on Stripe.

Modifies customer syncing actions and management command to handle situation where customer is deleted remotely but not locally.

Any background context you want to provide?

What ticket or issue # does this fix?

Closes #268

Definition of Done (check if considered and/or addressed):

  • Are all backwards incompatible changes documented in this PR?
  • Have all new dependencies been documented in this PR?
  • Has the appropriate documentation been updated (if applicable)?
  • [x ] Have you written tests to prove this change works (if applicable)?

Credit to @tasn for work done in PR pinax#325 - this PR adds tests

Fixes pinax#268
Copy link
Contributor Author

hey @tasn,

New to git and wasn't sure how to proceed so asked the project owners in slack who said a resubmit and acknowledge your work in the PR would be OK.

Copy link

tasn commented Sep 5, 2017

Thanks for your reply, but it's not for them to decide, but rather the author (in this case me).

If you give me access to your forked repo, I can fix the PR for you.
Alternatively, the easiest way would be to amend your commit to remove my fixes, and have this PR only include the tests, and the maintainers would have to merge mine first.

Copy link

tasn commented Sep 5, 2017

I can see you submitted a new PR (#358). Please close this one.

Just to let you know, you can update a PR by (force) pushing to the PR branch, no need to start a new one.

@sprocket-9 sprocket-9 closed this Sep 5, 2017
@paltman paltman added this to the Samwise milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

sync_customers crashes for deleted customers
3 participants