Fixed a bug where if a subscription had a trial end of none, that the… #369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Update subscription code would crash on charge_immediately when trial_period was set to NULL in database (None). This would happen if there were plans with trial periods mixed with plans that do not have trial periods.
What's this PR do?
Makes sure the trial period is not 'None' before attempting a time comparison between trial_end and timezone.now()
Any background context you want to provide?
This happens when you try to 'charge_immediately' on a plan with no trial period, or no trial period plan was initially selected.
What ticket or issue # does this fix?
n/a
Closes
Definition of Done (check if considered and/or addressed):