Add __repr__ methods

[blueyed]

This is only done for Plan, Customer and Subscription for now, and open
for discussion.

It helps a lot when debugging and/or looking at locals in tracebacks.

TODO:

• tests

[paltman]

I’m generally in favor of this.

Any objection to using format() instead of %?

Also style wise I prefer skipping the multi line string, then making the argument list one argument per line as it’s easier to scan.

[blueyed]

You mean like

     def __repr__(self):
-        return ('Plan(pk=%r, name=%r, amount=%r, currency=%r, interval=%r, '
-                'interval_count=%r, trial_period_days=%r, stripe_id=%r)' % (
-                    self.pk, self.name, self.amount, self.currency,
-                    self.interval, self.interval_count,
-                    self.trial_period_days, self.stripe_id))
+        return ('Plan(pk={!r}, name={!r}, amount={!r}, currency={!r}, interval={!r}, '
+                'interval_count={!r}, trial_period_days={!r}, stripe_id={!r})'.format(
+                    self.pk,
+                    self.name,
+                    self.amount,
+                    self.currency,
+                    self.interval,
+                    self.interval_count,
+                    self.trial_period_days,
+                    self.stripe_id))

?

IMHO it makes the whole file harder to scan (by adding more lines).

[blueyed]

@paltman
ping

[paltman]

No, more like:

    def __repr__(self):
        return "Plan(pk={!r}, name={!r}, amount={!r}, currency={!r}, interval={!r}, interval_count={!r}, trial_period_days={!r}, stripe_id={!r})".format(
            self.pk,
            self.name,
            self.amount,
            self.currency,
            self.interval,
            self.interval_count,
            self.trial_period_days,
            self.stripe_id
        )

[blueyed]

Amended and added basic tests.

[paltman]

Hit by string string differences in py2 and py3 on the tests.

[blueyed]

How to handle this best?

AssertionError: "Plan(pk=None, name=u'My Plan', amount=Decimal('5'), currency=u'', interval=u'monthly', interval_count=1, trial_period_days=None, stripe_id=u'')" !=
               u"Plan(pk=None, name='My Plan', amount=Decimal('5'), currency='', interval='monthly', interval_count=1, trial_period_days=None, stripe_id='')"

[codecov]

Codecov Report

Merging #382 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   99.39%   99.39%   +<.01%     
==========================================
  Files          34       34              
  Lines        1651     1662      +11     
  Branches      134      135       +1     
==========================================
+ Hits         1641     1652      +11     
  Misses          5        5              
  Partials        5        5

Flag	Coverage Δ
#py27dj110	99.39% <100%> (ø)	⬆️
#py27dj111	99.39% <100%> (ø)	⬆️
#py27dj18	99.39% <100%> (ø)	⬆️
#py33dj18	99.39% <100%> (ø)	⬆️
#py34dj110	99.39% <100%> (ø)	⬆️
#py34dj111	99.39% <100%> (ø)	⬆️
#py34dj18	99.39% <100%> (ø)	⬆️
#py35dj110	99.39% <100%> (ø)	⬆️
#py35dj111	99.39% <100%> (ø)	⬆️
#py35dj18	99.39% <100%> (ø)	⬆️
#py35djmaster	99.39% <100%> (ø)	⬆️
#py36dj111	99.39% <100%> (ø)	⬆️
#py36djmaster	99.39% <100%> (ø)	⬆️

Impacted Files	Coverage Δ
pinax/stripe/models.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda68d4...0e922b9. Read the comment docs.

[blueyed]

This is really helpul while debugging btw!