Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler code #398

Merged
merged 1 commit into from Oct 13, 2017
Merged

Simpler code #398

merged 1 commit into from Oct 13, 2017

Conversation

ticosax
Copy link
Contributor

@ticosax ticosax commented Oct 13, 2017

What's this PR do?

Modify syntax for better readability

Definition of Done (check if considered and/or addressed):

  • Are all backwards incompatible changes documented in this PR?
  • Have all new dependencies been documented in this PR?
  • Has the appropriate documentation been updated (if applicable)?
  • Have you written tests to prove this change works (if applicable)?

@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files          34       34           
  Lines        1651     1651           
  Branches      134      134           
=======================================
  Hits         1641     1641           
  Misses          5        5           
  Partials        5        5
Flag Coverage Δ
#py27dj110 99.39% <100%> (ø) ⬆️
#py27dj111 99.39% <100%> (ø) ⬆️
#py27dj18 99.39% <100%> (ø) ⬆️
#py27dj19 99.39% <100%> (ø) ⬆️
#py33dj18 99.39% <100%> (ø) ⬆️
#py34dj110 99.39% <100%> (ø) ⬆️
#py34dj111 99.39% <100%> (ø) ⬆️
#py34dj18 99.39% <100%> (ø) ⬆️
#py34dj19 99.39% <100%> (ø) ⬆️
#py35dj110 99.39% <100%> (ø) ⬆️
#py35dj111 99.39% <100%> (ø) ⬆️
#py35dj18 99.39% <100%> (ø) ⬆️
#py35dj19 99.39% <100%> (ø) ⬆️
#py35djmaster 99.39% <100%> (ø) ⬆️
#py36dj111 99.39% <100%> (ø) ⬆️
#py36djmaster 99.39% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pinax/stripe/actions/customers.py 100% <100%> (ø) ⬆️
pinax/stripe/actions/charges.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b1588...0930f3f. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files          34       34           
  Lines        1651     1651           
  Branches      134      134           
=======================================
  Hits         1641     1641           
  Misses          5        5           
  Partials        5        5
Flag Coverage Δ
#py27dj110 99.39% <100%> (ø) ⬆️
#py27dj111 99.39% <100%> (ø) ⬆️
#py27dj18 99.39% <100%> (ø) ⬆️
#py27dj19 99.39% <100%> (ø) ⬆️
#py33dj18 99.39% <100%> (ø) ⬆️
#py34dj110 99.39% <100%> (ø) ⬆️
#py34dj111 99.39% <100%> (ø) ⬆️
#py34dj18 99.39% <100%> (ø) ⬆️
#py34dj19 99.39% <100%> (ø) ⬆️
#py35dj110 99.39% <100%> (ø) ⬆️
#py35dj111 99.39% <100%> (ø) ⬆️
#py35dj18 99.39% <100%> (ø) ⬆️
#py35dj19 99.39% <100%> (ø) ⬆️
#py35djmaster 99.39% <100%> (ø) ⬆️
#py36dj111 99.39% <100%> (ø) ⬆️
#py36djmaster 99.39% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pinax/stripe/actions/charges.py 100% <100%> (ø) ⬆️
pinax/stripe/actions/customers.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b1588...0930f3f. Read the comment docs.

@paltman paltman merged commit d93cbd1 into pinax:master Oct 13, 2017
@paltman paltman added this to the Samwise milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants