Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connect] Allow Direct Charges #399

Merged
merged 3 commits into from Oct 25, 2017
Merged

Conversation

ticosax
Copy link
Contributor

@ticosax ticosax commented Oct 13, 2017

What's this PR do?

Stripe Connect support several scheme for creating charges.
This add support for one of them.

Any background context you want to provide?

https://stripe.com/docs/connect/direct-charges

Definition of Done (check if considered and/or addressed):

  • Are all backwards incompatible changes documented in this PR?
  • Have all new dependencies been documented in this PR?
  • Has the appropriate documentation been updated (if applicable)?
  • Have you written tests to prove this change works (if applicable)?

@ticosax ticosax force-pushed the direct-charges branch 2 times, most recently from 3604e1d to 15f78d1 Compare Oct 13, 2017
tox.ini Outdated
@@ -1,7 +1,7 @@
[flake8]
ignore = E265,E501
max-line-length = 100
max-complexity = 10
max-complexity = 11
exclude = pinax/stripe/migrations/*,docs/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was already getting concerned with the excessive branching. I wonder if there is a way to simplify rather than increase the complexity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked myself the same question... and conclude it is not worth it. There is no duplication, that's the nature of the validation of parameters that's makes it complex, therefore to read it remain simple.
Maybe I could add an exception only for this function ?
Your call.

@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #399 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #399      +/-   ##
=========================================
+ Coverage   99.39%   99.4%   +<.01%     
=========================================
  Files          34      34              
  Lines        1662    1668       +6     
  Branches      135     137       +2     
=========================================
+ Hits         1652    1658       +6     
  Misses          5       5              
  Partials        5       5
Flag Coverage Δ
#py27dj110 99.4% <100%> (ø) ⬆️
#py27dj111 99.4% <100%> (ø) ⬆️
#py27dj18 99.4% <100%> (ø) ⬆️
#py34dj110 99.4% <100%> (ø) ⬆️
#py34dj111 99.4% <100%> (ø) ⬆️
#py34dj18 99.4% <100%> (ø) ⬆️
#py34dj20 99.4% <100%> (ø) ⬆️
#py35dj110 99.4% <100%> (ø) ⬆️
#py35dj111 99.4% <100%> (ø) ⬆️
#py35dj18 99.4% <100%> (ø) ⬆️
#py35dj20 99.4% <100%> (ø) ⬆️
#py36dj111 99.4% <100%> (ø) ⬆️
#py36dj20 99.4% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pinax/stripe/actions/charges.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1f3b8...512727e. Read the comment docs.

ticosax added 2 commits Oct 15, 2017
Stripe Connect support several scheme for creating charges.
This add support for one of them.
https://stripe.com/docs/connect/direct-charges
@ticosax
Copy link
Contributor Author

ticosax commented Oct 15, 2017

Second commit is an attempt to bring back max-complexity to 10.
Not sure it is better, but still OK IMHO.

@paltman paltman added this to the Samwise milestone Oct 20, 2017
@paltman paltman merged commit 1b993f8 into pinax:master Oct 25, 2017
@kinesii
Copy link

kinesii commented Nov 26, 2017

How do you issue a direct charge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants