models: use blank=True with nullable JSONFields#412
Merged
paltman merged 4 commits intopinax:masterfrom Oct 25, 2017
Merged
Conversation
blueyed
added a commit
to blueyed/pinax-stripe
that referenced
this pull request
Oct 17, 2017
The user ForeignKey is nullable and should have blank=True then for the admin. Based on pinax#412.
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 34 34
Lines 1651 1651
Branches 134 134
=======================================
Hits 1641 1641
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 34 34
Lines 1662 1662
Branches 135 135
=======================================
Hits 1652 1652
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
paltman
approved these changes
Oct 20, 2017
blueyed
added a commit
to blueyed/pinax-stripe
that referenced
this pull request
Oct 26, 2017
The user ForeignKey is nullable and should have blank=True then for the admin. Based on pinax#412.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.