Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclassing MiddlewareMixin for django > 1.10 #349

Merged
merged 5 commits into from Aug 25, 2017

Conversation

@gregnewman
Copy link
Contributor

@gregnewman gregnewman commented Aug 16, 2017

What's this PR do?

Upgrade pre-Django 1.10-style middleware for Django > 1.10.
Some users were reporting problems using the ActiveSubscriptionMiddleware middleware.

Documentation on the change

Issues: #347

gregnewman added 5 commits Aug 16, 2017
To upgrade pre-Django 1.10-style middleware, Django provides this mixin.
Some users were reporting problems using the ActiveSubscriptionMiddleware middleware.
@gregnewman gregnewman self-assigned this Aug 17, 2017
@gregnewman gregnewman requested a review from paltman Aug 17, 2017
@paltman
Copy link
Member

@paltman paltman commented Aug 25, 2017

Closes #347

@paltman paltman merged commit 738e3f4 into pinax:master Aug 25, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@paltman paltman added this to the Samwise milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.