New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate quantity fields #351

Merged
merged 2 commits into from Aug 28, 2017

Conversation

Projects
None yet
2 participants
@gregnewman
Contributor

gregnewman commented Aug 25, 2017

What's this PR do?

For some reason, there were two quantity fields on InvoiceItem. Integerfield is the correct one so the other was removed.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What ticket or issue # does this fix?

#318

Definition of Done (check if considered and/or addressed):

  • [] Does this contain breaking changes? No
  • [] Does this add new dependencies? No
  • [] Will this feature require a new piece of infrastructure be implemented? No
  • [] Did you update internal documentation appropriately? Yes

gregnewman added some commits Aug 25, 2017

remove extra quantity field
For some reason, there were two quantity fields on InvoiceItem.  Integerfield is the correct one so the other was removed.

@paltman paltman changed the title from 318 quantity fields to Remove duplicate quantity fields Aug 28, 2017

@paltman paltman merged commit 2f29f98 into pinax:master Aug 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@paltman paltman added this to the Samwise milestone Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment