Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
What's this PR do?
So the api doesn’t get called everytime
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What ticket or issue # does this fix?
Definition of Done (check if considered and/or addressed):
I think we are fine: 1. Most use cases will only populate this for the lifetime of the web request/response. 2. The Stripe id doesn't change for an object.…
Sent from my iPhone
On Aug 26, 2017, at 1:48 PM, Daniel Hahler ***@***.***> wrote: @blueyed commented on this pull request. Is it necessary to invalidate the cache in some case(s)? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.