Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache stripe_customer #353

Merged
merged 1 commit into from Aug 28, 2017
Merged

Conversation

@gregnewman
Copy link
Contributor

@gregnewman gregnewman commented Aug 25, 2017

What's this PR do?

So the api doesn’t get called everytime Customer.stripe_customer is called, use a cached property.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What ticket or issue # does this fix?

Issues: #340

Definition of Done (check if considered and/or addressed):

  • [] Does this contain breaking changes? No
  • [] Does this add new dependencies? No
  • [] Will this feature require a new piece of infrastructure be implemented? No
  • [] Did you update internal documentation appropriately? Yes
So the api doesn’t get called everytime `Customer.stripe_customer` is called, use a cached property.
Copy link
Contributor

@blueyed blueyed left a comment

Is it necessary to invalidate the cache in some case(s)?

@paltman
Copy link
Member

@paltman paltman commented Aug 26, 2017

@paltman paltman merged commit c61dfad into pinax:master Aug 28, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 28, 2017

Thank you!

@paltman paltman added this to the Samwise milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.