Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of syncing deleted customers #358

Merged
merged 4 commits into from Sep 21, 2017

Conversation

@spr0cketeer
Copy link
Contributor

@spr0cketeer spr0cketeer commented Sep 5, 2017

What's this PR do?

Modifies deleted customer webhook to purge customer locally and not attempt to delete customer again on Stripe.

Modifies customer syncing actions and management command to handle situation where customer is deleted remotely but not locally.

Any background context you want to provide?

What ticket or issue # does this fix?

Closes #268

Definition of Done (check if considered and/or addressed):

  • Are all backwards incompatible changes documented in this PR?
  • Have all new dependencies been documented in this PR?
  • Has the appropriate documentation been updated (if applicable)?
  • Have you written tests to prove this change works (if applicable)?
@spr0cketeer
Copy link
Contributor Author

@spr0cketeer spr0cketeer commented Sep 5, 2017

@tasn used cherry pick on your commits and resubmitted this PR - does this look OK to you?

@tasn
Copy link
Contributor

@tasn tasn commented Sep 5, 2017

This looks great. Thank you.

Also, extra thank you for adding the tests to finally get this PR merged in!

Edit: forgot to mention, I'll now abandon my PR in favour of this one.

@spr0cketeer
Copy link
Contributor Author

@spr0cketeer spr0cketeer commented Sep 5, 2017

@tasn great! Learned a lot of new git skills doing this too 👍

@tasn
Copy link
Contributor

@tasn tasn commented Sep 5, 2017

I was going to explain to you how to do it, but since you said you were new to git, I thought it may be too complex.

Glad you managed to do it on your own and learn new tricks on the way. Git is a powerful tool, you can do very cool things with it.

if cu is None:
cu = customer.stripe_customer

if cu.get('deleted', False):

This comment has been minimized.

@paltman

paltman Sep 18, 2017
Member

Just a small thing, but can you change to double-quotes to keep consistent with project style? Thanks!

This comment has been minimized.

@spr0cketeer

spr0cketeer Sep 18, 2017
Author Contributor

@paltman np, done!

tasn and others added 4 commits Mar 10, 2017
@spr0cketeer spr0cketeer force-pushed the spr0cketeer:268-fix-resubmit branch from 5102b47 to 1224287 Sep 18, 2017
@spr0cketeer
Copy link
Contributor Author

@spr0cketeer spr0cketeer commented Sep 21, 2017

@paltman added a commit to use double quotes so this PR is good to go.

@paltman paltman merged commit 158948b into pinax:master Sep 21, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@tasn
Copy link
Contributor

@tasn tasn commented Sep 22, 2017

Thanks everyone. Happy it's finally in!

@paltman paltman added this to the Samwise milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.