New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriptions.create: use customer's stripe_id #392

Merged
merged 2 commits into from Oct 25, 2017

Conversation

Projects
None yet
3 participants
@blueyed
Copy link
Contributor

blueyed commented Oct 9, 2017

This avoids having to mock fetching the customer in tests, and should be better in general.

Needs test adjustments in case this makes sense.

@blueyed blueyed changed the title subscriptions.create: use customer's stripe_id [RFC] subscriptions.create: use customer's stripe_id Oct 9, 2017

@paltman

This comment has been minimized.

Copy link
Member

paltman commented Oct 10, 2017

👍 Great idea. Go for it!

@blueyed blueyed changed the title [RFC] subscriptions.create: use customer's stripe_id [WIP] subscriptions.create: use customer's stripe_id Oct 16, 2017

@blueyed blueyed force-pushed the blueyed:subscription-without-fetching-customer branch from 8d651bf to f61ae79 Oct 16, 2017

@blueyed blueyed changed the title [WIP] subscriptions.create: use customer's stripe_id [RDY] subscriptions.create: use customer's stripe_id Oct 16, 2017

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 16, 2017

Codecov Report

Merging #392 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files          34       34           
  Lines        1662     1662           
  Branches      135      135           
=======================================
  Hits         1652     1652           
  Misses          5        5           
  Partials        5        5
Flag Coverage Δ
#py27dj110 99.39% <100%> (ø) ⬆️
#py27dj111 99.39% <100%> (ø) ⬆️
#py27dj18 99.39% <100%> (ø) ⬆️
#py34dj110 99.39% <100%> (ø) ⬆️
#py34dj111 99.39% <100%> (ø) ⬆️
#py34dj18 99.39% <100%> (ø) ⬆️
#py34dj20 99.39% <100%> (ø) ⬆️
#py35dj110 99.39% <100%> (ø) ⬆️
#py35dj111 99.39% <100%> (ø) ⬆️
#py35dj18 99.39% <100%> (ø) ⬆️
#py35dj20 99.39% <100%> (ø) ⬆️
#py36dj111 99.39% <100%> (ø) ⬆️
#py36dj20 99.39% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pinax/stripe/actions/subscriptions.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1f3b8...80ffc95. Read the comment docs.

@blueyed

This comment has been minimized.

Copy link
Contributor Author

blueyed commented Oct 17, 2017

Ready.

@paltman paltman added this to the Samwise milestone Oct 20, 2017

@blueyed blueyed changed the title [RDY] subscriptions.create: use customer's stripe_id subscriptions.create: use customer's stripe_id Oct 20, 2017

@paltman paltman merged commit 86af78d into pinax:master Oct 25, 2017

16 checks passed

ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py27dj110 Your tests passed on CircleCI!
Details
ci/circleci: py27dj111 Your tests passed on CircleCI!
Details
ci/circleci: py27dj18 Your tests passed on CircleCI!
Details
ci/circleci: py34dj110 Your tests passed on CircleCI!
Details
ci/circleci: py34dj111 Your tests passed on CircleCI!
Details
ci/circleci: py34dj18 Your tests passed on CircleCI!
Details
ci/circleci: py34dj20 Your tests passed on CircleCI!
Details
ci/circleci: py35dj110 Your tests passed on CircleCI!
Details
ci/circleci: py35dj111 Your tests passed on CircleCI!
Details
ci/circleci: py35dj18 Your tests passed on CircleCI!
Details
ci/circleci: py35dj20 Your tests passed on CircleCI!
Details
ci/circleci: py36dj111 Your tests passed on CircleCI!
Details
ci/circleci: py36dj20 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.39%)
Details
codecov/project 99.39% (+0%) compared to 6a1f3b8
Details

@blueyed blueyed deleted the blueyed:subscription-without-fetching-customer branch Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment