Convert to Semantic Markup #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer need template tags as messages are semantic
paltman
commented
Oct 15, 2017
| {% comment "figure out how to detect other pinax apps and dynamically add here" %}{% endcomment %} | ||
| <a class="notice-settings" href="{% url "pinax_notifications:notice_settings" %}"> | ||
| {% trans "Notices" %} | ||
| </a> |
There was a problem hiding this comment.
@brosner There are a couple ways I can think of adding this capability. One being a context processor that ships with the theme that does some INSTALLED_APPS inspection and provides a variable switch on. But I wanted to check with you to see what you thought.
|
This work has been pushed to https://github.com/pinax/pinax-templates and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I have converted all the templates that ship with this app to semantic markup.
Now I'm working on providing some style maps as outlined in this blog post over in a project that I've built to support rapid template development and maintenance.
Investigate if I should be doing something better than using
@extendor maybe I'm using it wrong, as now that I'm extending more and more of some of the same rules, it seems to be breaking other parts of the style.To Style