New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Semantic Markup #133
Conversation
No longer need template tags as messages are semantic
{% comment "figure out how to detect other pinax apps and dynamically add here" %}{% endcomment %} | ||
<a class="notice-settings" href="{% url "pinax_notifications:notice_settings" %}"> | ||
{% trans "Notices" %} | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brosner There are a couple ways I can think of adding this capability. One being a context processor that ships with the theme that does some INSTALLED_APPS
inspection and provides a variable switch on. But I wanted to check with you to see what you thought.
This work has been pushed to https://github.com/pinax/pinax-templates and |
I have converted all the templates that ship with this app to semantic markup.
Now I'm working on providing some style maps as outlined in this blog post over in a project that I've built to support rapid template development and maintenance.
Investigate if I should be doing something better than using
@extend
or maybe I'm using it wrong, as now that I'm extending more and more of some of the same rules, it seems to be breaking other parts of the style.To Style