Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Semantic Markup #133

Closed
wants to merge 29 commits into from
Closed

Convert to Semantic Markup #133

wants to merge 29 commits into from

Conversation

@paltman
Copy link
Member

paltman commented May 1, 2017

I have converted all the templates that ship with this app to semantic markup.

Now I'm working on providing some style maps as outlined in this blog post over in a project that I've built to support rapid template development and maintenance.

Investigate if I should be doing something better than using @extend or maybe I'm using it wrong, as now that I'm extending more and more of some of the same rules, it seems to be breaking other parts of the style.

To Style

  • general
  • django-user-accounts
  • pinax-blog
  • pinax-notifications
  • pinax-cohorts
  • pinax-announcements
  • pinax-stripe
  • pinax-messages
  • pinax-likes
  • pinax-invitations
  • pinax-documents
paltman added 15 commits May 1, 2017
No longer need template tags as messages are semantic
{% comment "figure out how to detect other pinax apps and dynamically add here" %}{% endcomment %}
<a class="notice-settings" href="{% url "pinax_notifications:notice_settings" %}">
{% trans "Notices" %}
</a>

This comment has been minimized.

@paltman

paltman Oct 15, 2017 Author Member

@brosner There are a couple ways I can think of adding this capability. One being a context processor that ships with the theme that does some INSTALLED_APPS inspection and provides a variable switch on. But I wanted to check with you to see what you thought.

paltman added 14 commits Oct 16, 2017
@paltman paltman changed the title WIP: Convert to Semantic Markup Convert to Semantic Markup Oct 30, 2017
@paltman
Copy link
Member Author

paltman commented Oct 30, 2017

This work has been pushed to https://github.com/pinax/pinax-templates and pinax-templates 0.1 is now on PyPI

@paltman paltman closed this Oct 30, 2017
@paltman paltman deleted the semantic branch Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.