Fix issue with recently committed account code when EMAIL_AUTHENTICATION is True #38

Merged
merged 1 commit into from Jan 18, 2012

Projects

None yet

2 participants

@nduthoit

in apps.account.forms the LoginForm.is_valid method that would break if EMAIL_AUTHENTICATION was set to true because it looks for the 'username' key in the form data which does not exist when EMAIL_AUTHENTICATION is set to True.

@lukeman
Member
lukeman commented Jan 18, 2012

Good catch. Thanks for taking the time to provide a fix.

@lukeman lukeman merged commit 8ee4edb into pinax:master Jan 18, 2012
@nduthoit

No problem, I would have even created a ticket :) but I got the following
error http://cl.ly/431U0s2U022m1P0u201o when signing up to
code.pinaxproject.com

On Tue, Jan 17, 2012 at 11:15 PM, Luke Hatcher <
reply@reply.github.com

wrote:

Good catch. Thanks for taking the time to provide a fix.


Reply to this email directly or view it on GitHub:
#38 (comment)

Nathan Duthoit

The information contained in this e-mail message and any attachments may be
privileged and confidential. If the reader of this message is not the
intended recipient or an agent responsible for delivering it to the
intended recipient, you are hereby notified that any review, dissemination,
distribution or copying of this communication is strictly prohibited. If
you have received this communication in error, please notify the sender
immediately by replying to this e-mail and delete the message and any
attachments from your computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment