Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make Pinax compatible with Django 1.4 timezone support. #42

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

nigma commented Feb 21, 2012

This patch uses django.utils.timezone.now if available and fallbacks to datetime.datetime.now otherwise.

Owner

brosner commented Feb 21, 2012

I am not a fan of using now as a global variable name. I see now as a better local variable name capturing the datetime object in local scope. Can we rename the function to nowf? I am open to other suggestions. I've chosen nowf due to its length and how it very slightly describes itself. I like the pronunciation of /naʊɛf/ ;-)

nigma commented Feb 21, 2012

I totally agree. I'm actually used to using fully namespaced datetime.datetime.* and datetime.date.* because I don't like to import date into module namespace.

I'm still looking for a better alias for now. The nowf seems fine although it may look as a typo at first.

nigma commented Feb 22, 2012

tznow maybe?

Owner

brosner commented Mar 18, 2012

Due to some discussions during PyCon 2012 we've decided to take some new direction with Pinax. As I've pointed out in #43 we are putting new efforts in more external apps. django-user-accounts will target 1.4. This solves any aliasing we were discussing.

@brosner brosner closed this Mar 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment