Tiny change to make sponsor entries addressable #21

Merged
merged 2 commits into from Jan 24, 2013

Projects

None yet

3 participants

@holdenweb
Contributor

Just adds an id attribute to both tags to allow use of fragment identifiers.

@trbs
trbs commented on 2e7f825 Jan 21, 2013

wouldn't it be nicer to have a separator between the name and id ?
and use .pk instead of .id

Like:

+        <img id="sponsor_{{ sponsor.pk }}" src="{% thumbnail sponsor.logo '150x150' %}" alt="{{ sponsor.name }}" />
Owner

Yeah, much. Looks much more sensible, thanks. Presumably pk because that always maps to something?

trbs replied Jan 21, 2013

Yeah, sponsor.pk will always map to the primary key of the Sponsor model, at this moment we can be sure that the primary is 'id' but if for some reason that would change in the future this should automatically change with it.

@holdenweb holdenweb Update symposion/templates/sponsorship/_sponsor_link.html
Improved reference format and used pk rather than id 
- thanks to trbs for the suggestion
8afa17b
@lukeman lukeman merged commit 91366dc into pinax:master Jan 24, 2013
@dkua dkua referenced this pull request in dkua/2013-web May 15, 2013
@taavi taavi Adds logo credit. Fixes #21. 0644d89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment