When a route references a missing controller, raise ActionController:…

…:RoutingError with a clearer message
pinetops · Aug 16, 2011 · dde5b87 · dde5b87
1 parent 5902391
commit dde5b87
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/actionpack/lib/action_dispatch/routing/route_set.rb b/actionpack/lib/action_dispatch/routing/route_set.rb
@@ -556,9 +556,13 @@ def recognize_path(path, environment = {})
             dispatcher = dispatcher.app
           end
 
-          if dispatcher.is_a?(Dispatcher) && dispatcher.controller(params, false)
-            dispatcher.prepare_params!(params)
-            return params
+          if dispatcher.is_a?(Dispatcher)
+            if dispatcher.controller(params, false)
+              dispatcher.prepare_params!(params)
+              return params
+            else
+              raise ActionController::RoutingError, "A route matches #{path.inspect}, but references missing controller: #{params[:controller].camelize}Controller"
+            end
           end
         end
 

diff --git a/actionpack/test/controller/routing_test.rb b/actionpack/test/controller/routing_test.rb
@@ -902,6 +902,16 @@ def test_route_constraints_with_options_method_condition_is_valid
     end
   end
 
+  def test_route_error_with_missing_controller
+    set.draw do
+      get    "/people" => "missing#index"
+    end
+
+    assert_raise(ActionController::RoutingError) {
+      set.recognize_path("/people", :method => :get)
+    }
+  end
+
   def test_recognize_with_encoded_id_and_regex
     set.draw do
       match 'page/:id' => 'pages#show', :id => /[a-zA-Z0-9\+]+/