New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refractor network chaos to support multiple network chaos on the same pod #788
Conversation
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
/run-e2e-tests |
1 similar comment
/run-e2e-tests |
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
/run-e2e-tests |
/run-e2e-tests |
/run-e2e-tests |
/run-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@WangXiangUSTC,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: chaos-mesh(slack). |
/run-e2e-tests |
What problem does this PR solve?
Part of #718. This PR brings a lot of new features to NetworkChaos:
Support multiple network chaos on the same pod.
Support target selector for bandwidth limit
What is changed and how does it work?
A new resource
PodNetworkChaos
is created to record the relation betweenIptables
,IPSet
andTc
rules and the chaos definitions.The implementation of the network partition is quite straightforward. If multiple network partition chaoses are set on the same pod,
all these ips/cidrs will be blocked.
For bandwidth limit and netem chaos, the final traffic control tree will be like:
All netem/bandwidth chaos without a filter will be piped at the beginning of qdisc (and linked to root qdisc). The netem/bandwidth chaos with a filter will be set on one band of PRIO qdisc.
Limitation: Only one netem/tbf qdisc with a filter will be applied, so that if you are applying two netem/tbf chaos and their targets overlapped, only one of them takes effect (for the pod in the intersection of their targets).
Check List
Tests
Code changes