add working group of sequence #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gingerkidney and
winkyao
and removed request for
a team
|
|
zz-jason
reviewed
Dec 2, 2019
working-groups/wg-tidb-sequence.md
Outdated
|
|
||
| Support Sequence in TiDB | ||
|
|
||
| * Many customers could probably make do with using Auto_Increment as unique id generator, |
There was a problem hiding this comment.
Suggested change
| * Many customers could probably make do with using Auto_Increment as unique id generator, | |
| Many customers could probably choose `AUTO_INCREMENT` as the unique ID | |
| generator. |
There was a problem hiding this comment.
Only one line - no need of list.
working-groups/wg-tidb-sequence.md
Outdated
| ## Organizers | ||
|
|
||
| * [ailinkid](https://github.com/AilinKid), [PingCAP](https://github.com/pingcap) | ||
| * [andrewdi](https://github.com/AndrewDi), [Personal](pandipd@outlook.com) |
There was a problem hiding this comment.
Suggested change
| * [andrewdi](https://github.com/AndrewDi), [Personal](pandipd@outlook.com) | |
| * [andrewdi](https://github.com/AndrewDi), [Personal](mailto:pandipd@outlook.com) |
zz-jason
reviewed
Dec 2, 2019
working-groups/wg-tidb-sequence.md
Outdated
|
|
||
| Support Sequence in TiDB | ||
|
|
||
| * Many customers could probably make do with using Auto_Increment as unique id generator, |
There was a problem hiding this comment.
@dcalvin Would you like to help us polish the words in this paragraph?
gingerkidney
reviewed
Dec 2, 2019
working-groups/wg-tidb-sequence.md
Outdated
| ## Contact | ||
|
|
||
| * Slack: channel **#wg-tidb-sequence** in the | ||
| [tidbcommunity](https://pingcap.com/tidbslack) slack workspace. |
There was a problem hiding this comment.
Suggested change
| [tidbcommunity](https://pingcap.com/tidbslack) slack workspace. | |
| [tidbcommunity](https://join.slack.com/t/tidbcommunity/shared_invite/enQtNzc0MzI4ODExMDc4LWYwYmIzMjZkYzJiNDUxMmZlN2FiMGJkZjAyMzQ5NGU0NGY0NzI3NTYwMjAyNGQ1N2I2ZjAxNzc1OGUwYWM0NzE) slack workspace. |
|
@zz-jason @gingerkidney PTAL |
dcalvin
reviewed
Dec 3, 2019
|
|
||
| ## Goals | ||
|
|
||
| Support Sequence in TiDB |
There was a problem hiding this comment.
Suggested change
| Support Sequence in TiDB | |
| The TiDB Sequence Working Group aims to implement the Sequence support in TiDB. |
There was a problem hiding this comment.
Suggest putting this sentence behind the next two.
working-groups/wg-tidb-sequence.md
Outdated
|
|
||
| Support Sequence in TiDB | ||
|
|
||
| * Many customers could probably make do with using Auto_Increment as unique id generator, |
There was a problem hiding this comment.
Only one line - no need of list.
working-groups/wg-tidb-sequence.md
Outdated
| Support Sequence in TiDB | ||
|
|
||
| * Many customers could probably make do with using Auto_Increment as unique id generator, | ||
| but in some cases, existing applications try to use sequences to fetch generated id back |
There was a problem hiding this comment.
Suggested change
| but in some cases, existing applications try to use sequences to fetch generated id back | |
| However, in some cases, existing applications try to use sequences to fetch the generated ID |
rleungx
pushed a commit
to rleungx/community
that referenced
this pull request
Jun 17, 2021
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add working group of Sequence.