Skip to content

Add warning about using tiflash in read write txn #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yikeke merged 6 commits into from
Jun 1, 2020
Merged

Add warning about using tiflash in read write txn #3396

yikeke merged 6 commits into from
Jun 1, 2020

Conversation

@zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented May 28, 2020

What is changed, added or deleted? (Required)

Add a warning about using tiflash in read write transaction.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@zanmato1984 zanmato1984 requested a review from yikeke May 28, 2020 10:15
@yikeke yikeke requested review from ilovesoup and kissmydb May 28, 2020 10:20
@yikeke yikeke added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. and removed translation/doing This PR’s assignee is translating this PR. labels May 28, 2020
yikeke
yikeke reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

zanmato1984 and others added 2 commits May 29, 2020 17:53
@zanmato1984 @yikeke
Update tiflash/use-tiflash.md
e67cd38 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@zanmato1984
Merge branch 'master' into tiflash-read-write-txn-warn
5b558ea
kissmydb
kissmydb approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yikeke
yikeke reviewed Jun 1, 2020
View reviewed changes
@yikeke
Copy link
Contributor

yikeke commented Jun 1, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 1, 2020

/run-all-tests

@yikeke yikeke added translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 1, 2020
@yikeke yikeke self-assigned this Jun 1, 2020
yikeke
yikeke reviewed Jun 1, 2020
View reviewed changes
@yikeke yikeke merged commit 2870893 into master Jun 1, 2020
@yikeke yikeke deleted the tiflash-read-write-txn-warn branch June 1, 2020 07:59
@yikeke
Copy link
Contributor

yikeke commented Jun 1, 2020

/run-cherry-picker

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 1, 2020
@zanmato1984 @sre-bot
cherry pick pingcap#3396 to release-4.0
200e949 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 1, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 1, 2020

cherry pick to release-4.0 in PR #3430

sre-bot added a commit that referenced this pull request Jun 1, 2020
@sre-bot
Add warning about using tiflash in read write txn (#3396) (#3430)
3aa7926
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@yikeke yikeke mentioned this pull request Jun 23, 2020
Merged
5 tasks
yikeke pushed a commit to pingcap/docs that referenced this pull request Jun 23, 2020
align pingcap/docs-cn#3396
908e77c
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 23, 2020
ti-srebot added a commit to pingcap/docs that referenced this pull request Jun 28, 2020
@yikeke @TomShawn @ti-srebot
Update use-tiflash.md from Special Week changes (#2972)
8cadd05 
* Update use-tiflash.md

* Update use-tiflash.md

* align the rest of https://github.com/pingcap/docs-cn/pull/3351/files

* align pingcap/docs-cn#3396

* align https://github.com/pingcap/docs-cn/pull/3687/files

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
@ti-srebot ti-srebot mentioned this pull request Jun 28, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilovesoup ilovesoup Awaiting requested review from ilovesoup

2 more reviewers

@yikeke yikeke yikeke left review comments

@kissmydb kissmydb kissmydb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yikeke yikeke

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zanmato1984 @yikeke @sre-bot @kissmydb