Skip to content

maintain: clear up some expressions #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 8, 2020
Merged

maintain: clear up some expressions #3494

merged 9 commits into from
Jun 8, 2020

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 4, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@yikeke yikeke marked this pull request as draft June 4, 2020 08:45
@yikeke yikeke mentioned this pull request Jun 4, 2020
Merged
5 tasks
yikeke
yikeke commented Jun 4, 2020
View reviewed changes
@yikeke yikeke mentioned this pull request Jun 5, 2020
Merged
5 tasks
@yikeke yikeke marked this pull request as ready for review June 5, 2020 02:21
@yikeke yikeke requested review from lilin90 and superlzs0476 June 5, 2020 02:22
@yikeke yikeke added needs-cherry-pick-4.0 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jun 5, 2020
@yikeke yikeke mentioned this pull request Jun 5, 2020
Merged
5 tasks
lilin90
lilin90 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor Author

yikeke commented Jun 8, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit 9d862fa into pingcap:master Jun 8, 2020
@sre-bot sre-bot mentioned this pull request Jun 8, 2020
Merged
5 tasks
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 8, 2020
@yikeke @sre-bot
cherry pick pingcap#3494 to release-4.0
9ec398d 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 8, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-4.0 in PR #3559

sre-bot added a commit that referenced this pull request Jun 8, 2020
@sre-bot @yikeke
maintain: clear up some expressions (#3494) (#3559)
20f6fd7 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@sre-bot sre-bot mentioned this pull request Jun 8, 2020
Merged
5 tasks
@sre-bot sre-bot mentioned this pull request Jun 9, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@superlzs0476 superlzs0476 Awaiting requested review from superlzs0476

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yikeke @sre-bot @lilin90