Skip to content

update key word #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2020
Merged

update key word #3635

merged 4 commits into from
Jun 14, 2020

Conversation

@kissmydb
Copy link
Contributor

@kissmydb kissmydb commented Jun 14, 2020 •
edited
Loading

modify wrong word

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@kissmydb
update
d5a47a9 
modify wrong word
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 14, 2020
@kissmydb kissmydb changed the title update update key word Jun 14, 2020
@kissmydb kissmydb requested review from jackysp and yikeke June 14, 2020 07:43
jackysp
jackysp reviewed Jun 14, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yikeke
yikeke reviewed Jun 14, 2020
View reviewed changes
yikeke
yikeke approved these changes Jun 14, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@yikeke
Copy link
Contributor

yikeke commented Jun 14, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 14, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 14, 2020

/run-all-tests

@sre-bot sre-bot merged commit 515e7fc into master Jun 14, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 14, 2020
@kissmydb @sre-bot
cherry pick pingcap#3635 to release-4.0
74dc66d 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 14, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 14, 2020

cherry pick to release-4.0 in PR #3636

@yikeke yikeke added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 14, 2020
sre-bot added a commit that referenced this pull request Jun 14, 2020
@sre-bot @kissmydb @yikeke
update key word (#3635) (#3636)
b87c974 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: kissmydb <likun@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@overvenus overvenus deleted the kissmydb-patch-3 branch June 16, 2020 05:41
@yikeke yikeke added translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 16, 2020
@TomShawn TomShawn mentioned this pull request Jun 16, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2020
Merged
5 tasks
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackysp jackysp jackysp left review comments

+1 more reviewer

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kissmydb @yikeke @sre-bot @jackysp @TomShawn