Skip to content

add SET ROLE document (#3358) #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2020
Merged

add SET ROLE document (#3358) #3660

merged 2 commits into from
Jun 15, 2020

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 15, 2020

cherry-pick #3358 to release-3.1

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-srebot
cherry pick pingcap#3358 to release-3.1
04c4028 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2020
Merged
5 tasks
@ti-srebot ti-srebot added special-week PR from Document Special Week. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. labels Jun 15, 2020
djshow832
djshow832 reviewed Jun 15, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke requested review from imtbkcat and removed request for jackysp, kissmydb and lilin90 June 15, 2020 10:51
yikeke
yikeke approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit 1e3ac24 into pingcap:release-3.1 Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djshow832 djshow832 djshow832 left review comments

@bb7133 bb7133 Awaiting requested review from bb7133

@imtbkcat imtbkcat Awaiting requested review from imtbkcat

+1 more reviewer

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@imtbkcat imtbkcat

Labels

special-week PR from Document Special Week. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @djshow832 @yikeke @imtbkcat