Skip to content

Conversation

@ti-srebot
Copy link
Contributor

cherry-pick #3307 to release-3.0


What is changed, added or deleted? (Required)

Add Chinese document for topn-limit-push-down.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added size/medium Changes of a medium size. special-week PR from Document Special Week. type/cherry-pick-for-release-3.0 This PR is cherry-picked to release-3.0 from a source PR. labels Jun 22, 2020
@ti-srebot
Copy link
Contributor Author

@LittleFall please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs-cn/invitations

@yikeke
Copy link
Contributor

yikeke commented Jun 22, 2020

@LittleFall seems on leave recently. Could you help fix the lint and add this file to TOC.md? @zz-jason

@yikeke yikeke added the status/require-change Needs the author to address comments. label Jun 22, 2020
@LittleFall
Copy link
Contributor

@yikeke sorry this lint makes me confused.
when I add the slash like [优化规则及表达式下推的黑名单](/blacklist-control-plan.md), it finds a dead link: /home/circleci/pingcap/docs-cn//blacklist-control-plan.md as lint(19480).
when I remove the slash like [优化规则及表达式下推的黑名单](blacklist-control-plan.md), it says link-must-start-with-slash:blacklist-control-plan.md as lint(19479).

@yikeke
Copy link
Contributor

yikeke commented Jun 23, 2020

@yikeke sorry this lint makes me confused.
when I add the slash like [优化规则及表达式下推的黑名单](/blacklist-control-plan.md), it finds a dead link: /home/circleci/pingcap/docs-cn//blacklist-control-plan.md as lint(19480).
when I remove the slash like [优化规则及表达式下推的黑名单](blacklist-control-plan.md), it says link-must-start-with-slash:blacklist-control-plan.md as lint(19479).

/blacklist-control-plan.md is the correct format. But the blacklist-control-plan.md doc has not been merged to release-3.0 branch, so there's this dead link and this PR should be merged after #3760 is merged.

@yikeke
Copy link
Contributor

yikeke commented Jun 24, 2020

@yikeke sorry this lint makes me confused.
when I add the slash like [优化规则及表达式下推的黑名单](/blacklist-control-plan.md), it finds a dead link: /home/circleci/pingcap/docs-cn//blacklist-control-plan.md as lint(19480).
when I remove the slash like [优化规则及表达式下推的黑名单](blacklist-control-plan.md), it says link-must-start-with-slash:blacklist-control-plan.md as lint(19479).

/blacklist-control-plan.md is the correct format. But the blacklist-control-plan.md doc has not been merged to release-3.0 branch, so there's this dead link and this PR should be merged after #3760 is merged.

#3760 is merged and the lint should pass now. Please add this file to TOC.md. @LittleFall

@ti-srebot
Copy link
Contributor Author

@ti-srebot, please update your pull request.

@yikeke yikeke merged commit 7ecec01 into pingcap:release-3.0 Jun 28, 2020
@yikeke yikeke deleted the release-3.0-75c37dc259bd branch June 28, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/medium Changes of a medium size. special-week PR from Document Special Week. status/require-change Needs the author to address comments. type/cherry-pick-for-release-3.0 This PR is cherry-picked to release-3.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants