Skip to content

*: fix descriptions and update format #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 28, 2020
Merged

*: fix descriptions and update format #3784

merged 8 commits into from
Jun 28, 2020

Conversation

@lilin90
Copy link
Member

@lilin90 lilin90 commented Jun 23, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Fix some wording and format issues brought by #3278 and #3166

  • Overview
  • TiKV thread pools

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@lilin90 lilin90 added translation/no-need No need to translate this PR. needs-cherry-pick-4.0 labels Jun 23, 2020
@lilin90 lilin90 added status/PTAL This PR is ready for reviewing. size/small Changes of a small size. labels Jun 23, 2020
TomShawn
TomShawn approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member Author

lilin90 commented Jun 23, 2020

@Little-Wallace PTAL

@lilin90 lilin90 requested a review from scsldb June 23, 2020 10:40
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 25, 2020

@TomShawn, @scsldb, @Little-Wallace, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 27, 2020

@TomShawn, @scsldb, @Little-Wallace, PTAL.

@lilin90 lilin90 requested a review from yikeke June 28, 2020 08:50
lilin90
lilin90 commented Jun 28, 2020
View reviewed changes
yikeke
yikeke approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 4fd3101 into pingcap:master Jun 28, 2020
@lilin90 lilin90 deleted the fix-description-format branch June 28, 2020 09:10
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 28, 2020
@lilin90 @ti-srebot
cherry pick pingcap#3784 to release-4.0
f8480ec 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 28, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 28, 2020

cherry pick to release-4.0 in PR #3801

@lilin90 lilin90 mentioned this pull request Jun 28, 2020
Merged
5 tasks
lilin90 added a commit that referenced this pull request Jun 28, 2020
@ti-srebot @lilin90
cherry pick #3784 to release-4.0 (#3801)
715759a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Lilian Lee <lilin@pingcap.com>
scsldb
scsldb reviewed Jun 29, 2020
View reviewed changes
@ti-srebot ti-srebot mentioned this pull request Jul 1, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Little-Wallace Little-Wallace Awaiting requested review from Little-Wallace

3 more reviewers

@scsldb scsldb scsldb left review comments

@yikeke yikeke yikeke approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/no-need No need to translate this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lilin90 @ti-srebot @scsldb @yikeke @TomShawn