Skip to content

Conversation

@ti-srebot
Copy link
Contributor

cherry-pick #4027 to release-3.1


What is changed, added or deleted? (Required)

Fixes #1768

Also addresses a minor issue in mysql-compatibility where in my #3151 I said that SELECT INTO OUTFILE may not be implemented, but it since has been.

Also propose moving "Compatibility -> MySQL Compatibility" to "MySQL Compatibility" in the menu, to simplify navigation, and add myself as a reviewer to mysql compatibility areas.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2020
5 tasks
@ti-srebot ti-srebot added size/small Changes of a small size. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. labels Jul 28, 2020
@ti-srebot
Copy link
Contributor Author

@TomShawn please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs-cn/invitations

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2020
@ti-srebot ti-srebot merged commit 5686046 into pingcap:release-3.1 Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants