Skip to content

Add IsolationLevel introduction for PD #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 30, 2020
Merged

Add IsolationLevel introduction for PD #4104

merged 14 commits into from
Jul 30, 2020

Conversation

@JmPotato
Copy link
Member

@JmPotato JmPotato commented Jul 29, 2020

Signed-off-by: JmPotato ghzpotato@gmail.com

What is changed, added or deleted? (Required)

PD adds a new config field named IsolationLevel. This pr adds the Chinese version introduction for it.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@JmPotato
Add a new config field IsolationLevel for PD
d660091 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Jul 29, 2020
@CLAassistant
Copy link

CLAassistant commented Jul 29, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JmPotato
Copy link
Member Author

JmPotato commented Jul 29, 2020 •
edited
Loading

@ti-srebot /cc @disksing @nolouch PTAL

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 29, 2020

@JmPotato No command or invalid command

1 similar comment
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 29, 2020

@JmPotato No command or invalid command

disksing
disksing reviewed Jul 29, 2020
View reviewed changes
JmPotato added 2 commits July 29, 2020 17:58
@JmPotato
Merge branch 'master' into JmPotato-patch-1
3e98626
@JmPotato
Address comment
ab6358f 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
disksing
disksing reviewed Jul 29, 2020
View reviewed changes
JmPotato added 2 commits July 29, 2020 19:53
@JmPotato
Merge branch 'master' into JmPotato-patch-1
06aebaf
@JmPotato
Address comment
53f68a9 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato requested a review from disksing July 29, 2020 11:56
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 30, 2020

@disksing,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

TomShawn
TomShawn reviewed Jul 30, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 30, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 30, 2020
View reviewed changes
JmPotato and others added 4 commits July 30, 2020 11:38
@JmPotato @TomShawn
Update configure-placement-rules.md
20377d2 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@JmPotato @TomShawn
Update schedule-replicas-by-topology-labels.md
02f6d56 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@JmPotato @TomShawn
Update schedule-replicas-by-topology-labels.md
066c431 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@JmPotato
Merge branch 'master' into JmPotato-patch-1
283aa01
@JmPotato JmPotato requested a review from TomShawn July 30, 2020 03:50
@JmPotato JmPotato mentioned this pull request Jul 30, 2020
Merged
5 tasks
TomShawn
TomShawn reviewed Jul 30, 2020
View reviewed changes
@TomShawn
Copy link
Contributor

TomShawn commented Jul 30, 2020

@JmPotato Does this PR also apply to other version(s)? If yes, please tick the box(es) in #4104 (comment).

@TomShawn TomShawn added size/large Changes of a large size. translation/doing This PR’s assignee is translating this PR. labels Jul 30, 2020
@JmPotato
Copy link
Member Author

JmPotato commented Jul 30, 2020

@JmPotato Does this PR also apply to other version(s)? If yes, please tick the box(es) in #4104 (comment).

No, it's only in the dev version.

JmPotato and others added 3 commits July 30, 2020 12:10
@JmPotato @TomShawn
Update schedule-replicas-by-topology-labels.md
af8c0a0 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@JmPotato @TomShawn
Update schedule-replicas-by-topology-labels.md
8285a90 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@JmPotato @TomShawn
Update schedule-replicas-by-topology-labels.md
ac9f8e3 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn added the v5.0 This PR/issue applies to TiDB v5.0 label Jul 30, 2020
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 30, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 30, 2020

PTAL again @TomShawn

TomShawn
TomShawn reviewed Jul 30, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2020
@TomShawn TomShawn merged commit ad0281d into pingcap:master Jul 30, 2020
@TomShawn TomShawn assigned JmPotato and unassigned ran-huang Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disksing disksing disksing approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JmPotato JmPotato

Labels

contribution This PR is from a community contributor. size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JmPotato @CLAassistant @ti-srebot @TomShawn @yikeke @disksing @ran-huang