Skip to content

partitioning: update docs #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 31, 2020
Merged

partitioning: update docs #4135

merged 4 commits into from
Jul 31, 2020

Conversation

@Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Jul 30, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Update some examples and a link in the relevant docs.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Jul 30, 2020

/label translation/no-need, needs-cherry-pick-4.0

@ti-srebot ti-srebot added needs-cherry-pick-4.0 translation/no-need No need to translate this PR. labels Jul 30, 2020
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Jul 30, 2020

/cc lilin90

@ti-srebot ti-srebot requested a review from lilin90 July 30, 2020 23:48
lilin90
lilin90 reviewed Jul 31, 2020
View reviewed changes
@lilin90 lilin90 added require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/require-change Needs the author to address comments. labels Jul 31, 2020
Joyinqin and others added 2 commits July 31, 2020 18:52
lilin90
lilin90 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 31, 2020
@lilin90 lilin90 merged commit 9367df7 into pingcap:master Jul 31, 2020
@lilin90 lilin90 removed the status/require-change Needs the author to address comments. label Jul 31, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 31, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#4135 to release-4.0
18c42b3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 31, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 31, 2020

cherry pick to release-4.0 in PR #4148

ti-srebot added a commit that referenced this pull request Jul 31, 2020
@ti-srebot @Joyinqin
partitioning: update docs (#4135) (#4148)
1169966 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Joyinqin @ti-srebot @lilin90