Skip to content

sql: add the mapping table for converting oracle functions to tidb functions #10582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 18 commits into from
Sep 30, 2022
Merged

sql: add the mapping table for converting oracle functions to tidb functions #10582

ti-chi-bot merged 18 commits into from
Sep 30, 2022

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Sep 29, 2022

What is changed, added or deleted? (Required)

Add the mappings between functions and sytax of Oracle and TiDB.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hfxsd hfxsd self-assigned this Sep 29, 2022
@hfxsd hfxsd marked this pull request as draft September 29, 2022 06:12
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2022
@hfxsd hfxsd marked this pull request as ready for review September 29, 2022 10:18
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2022
@hfxsd hfxsd requested a review from Oreoxmt September 29, 2022 10:19
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/best-practices Adds or updates TiDB best practices. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. and removed missing-translation-status This PR does not have translation status info. labels Sep 29, 2022
hfxsd
hfxsd commented Sep 29, 2022
View reviewed changes
hfxsd
hfxsd commented Sep 29, 2022
View reviewed changes
hfxsd
hfxsd commented Sep 29, 2022
View reviewed changes
hfxsd
hfxsd commented Sep 29, 2022
View reviewed changes
hfxsd
hfxsd commented Sep 29, 2022
View reviewed changes
Oreoxmt
Oreoxmt approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 30, 2022
hfxsd
hfxsd commented Sep 30, 2022
View reviewed changes
@hfxsd
Copy link
Collaborator Author

hfxsd commented Sep 30, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 30, 2022

@hfxsd: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hfxsd hfxsd added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 30, 2022
@hfxsd
Copy link
Collaborator Author

hfxsd commented Sep 30, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 30, 2022

This pull request has been accepted and is ready to merge.

Commit hash: 8a6c808

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 30, 2022
@ti-chi-bot ti-chi-bot merged commit ef7f38a into pingcap:master Sep 30, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 30, 2022

In response to a cherrypick label: new pull request created: #10620.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 30, 2022

In response to a cherrypick label: new pull request created: #10621.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 30, 2022

In response to a cherrypick label: new pull request created: #10622.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 30, 2022

In response to a cherrypick label: new pull request created: #10623.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 30, 2022

In response to a cherrypick label: new pull request created: #10624.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
12 tasks
ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
sql: add the mapping table for converting oracle functions to tidb fu…
041c8f6 
…nctions (#10582) (#10620)
ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
sql: add the mapping table for converting oracle functions to tidb fu…
1035b65 
…nctions (#10582) (#10622)
ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
sql: add the mapping table for converting oracle functions to tidb fu…
74dac5b 
…nctions (#10582) (#10621)
ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
sql: add the mapping table for converting oracle functions to tidb fu…
78042fb 
…nctions (#10582) (#10623)
ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
sql: add the mapping table for converting oracle functions to tidb fu…
430358e 
…nctions (#10582) (#10624)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@shichun-0415 shichun-0415 Awaiting requested review from shichun-0415

+2 more reviewers

@jinwhu jinwhu jinwhu approved these changes

@Dongdong-Bryant Dongdong-Bryant Dongdong-Bryant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hfxsd hfxsd

Labels

area/best-practices Adds or updates TiDB best practices. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hfxsd @ti-chi-bot @Oreoxmt @jinwhu @Dongdong-Bryant