Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix many typos #1603

Merged
merged 2 commits into from Oct 18, 2019
Merged

*: fix many typos #1603

merged 2 commits into from Oct 18, 2019

Conversation

xiekeyi98
Copy link
Contributor

@xiekeyi98 xiekeyi98 commented Oct 18, 2019

Signed-off-by: keyixie keyixie@tencent.com

What is changed, added or deleted?

  1. Fix Many misspells.
    By the way : someone may not a misspell , just a difference with American and England .

This change is Reviewable

Signed-off-by: keyixie <keyixie@tencent.com>
@lilin90 lilin90 changed the title [typos] Fix Many misspell *: fix many typos Oct 18, 2019
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member

lilin90 commented Oct 18, 2019

@xiekeyi98 Sharp eyes~ Thanks a lot for improving docs!

@lilin90 lilin90 merged commit 914b7a1 into pingcap:master Oct 18, 2019
@xiekeyi98
Copy link
Contributor Author

@xiekeyi98 Sharp eyes~ Thanks a lot for improving docs!

@lilin90 Not me, just many great tools to help me make our docs pretty.

nitpicking,I think we could use some checks for this repo.
Emmm , Like CI in the tidb.

Here may have some great tools for us.
image

@lilin90
Copy link
Member

lilin90 commented Oct 18, 2019

@xiekeyi98 Good idea! Currently, we use some extensions in VS Code to help check spelling errors, but we cannot guarantee no PR has typos. Adding ti to CI check would be better.

@yikeke Could you please help follow up this? Thanks!

@yikeke
Copy link
Contributor

yikeke commented Oct 18, 2019

@xiekeyi98 Good idea! Currently, we use some extensions in VS Code to help check spelling errors, but we cannot guarantee no PR has typos. Adding ti to CI check would be better.

@yikeke Could you please help follow up this? Thanks!

Sure, I‘ll look for a tool and integrate the misspelling CI check into our docs/docs-cn repo. @lilin90

Thanks for the advice! @xiekeyi98

@xiekeyi98
Copy link
Contributor Author

xiekeyi98 commented Oct 18, 2019

@xiekeyi98 Good idea! Currently, we use some extensions in VS Code to help check spelling errors, but we cannot guarantee no PR has typos. Adding ti to CI check would be better.
@yikeke Could you please help follow up this? Thanks!

Sure, I‘ll look for a tool and integrate the misspelling check into our docs/docs-cn repo. @lilin90

Thanks for the advice! @xiekeyi98

Here are some gossip.
We should be careful for some spell like nickname or slang.
For example, Misspell tool tells me it is a misspell , indeed, it just a nickname.
Luckly, many tools can ignore some pattern.
And we may need the developer to help us make a shell or script.
image

@sre-bot sre-bot added the contribution Indicates that the PR was contributed by an external member. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Indicates that the PR was contributed by an external member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants