From cbcbc5216c344dbba709c827f684c78c7fe6ce3a Mon Sep 17 00:00:00 2001 From: zkthernum Date: Mon, 1 Jan 2024 19:03:47 +0800 Subject: [PATCH 1/4] add translation --- tiflash/tune-tiflash-performance.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tiflash/tune-tiflash-performance.md b/tiflash/tune-tiflash-performance.md index f17c9b6176cfd..2fde2943a4864 100644 --- a/tiflash/tune-tiflash-performance.md +++ b/tiflash/tune-tiflash-performance.md @@ -305,7 +305,8 @@ The [`tidb_max_tiflash_threads`](/system-variables.md#tidb_max_tiflash_threads-n set @@tidb_max_tiflash_threads = 20; ``` -The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before the re-configuration, the execution concurrency of all TiFlash operators is 24. After the value of this variable changes to `20`, the concurrency becomes 60. +The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. The cluster has a total of 3 TiFlash instances, so the total number of threads executed by requests on all TiFlash instances is 24. When `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60. + Before `tidb_max_tiflash_threads` is re-configured: From 5b48f3fd7cefec3365e2d6b25145826e62032e43 Mon Sep 17 00:00:00 2001 From: zkthernum Date: Tue, 9 Jan 2024 18:40:04 +0800 Subject: [PATCH 2/4] add some explanation for tiflash tuning performance doc --- tiflash/tune-tiflash-performance.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tiflash/tune-tiflash-performance.md b/tiflash/tune-tiflash-performance.md index 2fde2943a4864..8e2a6ff83de7f 100644 --- a/tiflash/tune-tiflash-performance.md +++ b/tiflash/tune-tiflash-performance.md @@ -305,8 +305,7 @@ The [`tidb_max_tiflash_threads`](/system-variables.md#tidb_max_tiflash_threads-n set @@tidb_max_tiflash_threads = 20; ``` -The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. The cluster has a total of 3 TiFlash instances, so the total number of threads executed by requests on all TiFlash instances is 24. When `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60. - +The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. The cluster has a total of 3 TiFlash instances, so the total number of threads executed by requests on all TiFlash instances is 24(8 × 3). When `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60(20 × 3). Before `tidb_max_tiflash_threads` is re-configured: From 22f6b3333974f8940b429d58414658ef44d4ca53 Mon Sep 17 00:00:00 2001 From: Aolin Date: Wed, 24 Jan 2024 10:20:57 +0800 Subject: [PATCH 3/4] Apply suggestions from code review --- tiflash/tune-tiflash-performance.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tiflash/tune-tiflash-performance.md b/tiflash/tune-tiflash-performance.md index 8e2a6ff83de7f..999ab8eee5db2 100644 --- a/tiflash/tune-tiflash-performance.md +++ b/tiflash/tune-tiflash-performance.md @@ -305,7 +305,7 @@ The [`tidb_max_tiflash_threads`](/system-variables.md#tidb_max_tiflash_threads-n set @@tidb_max_tiflash_threads = 20; ``` -The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. The cluster has a total of 3 TiFlash instances, so the total number of threads executed by requests on all TiFlash instances is 24(8 × 3). When `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60(20 × 3). +The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. Since the cluster has a total of 3 TiFlash instances, the total number of threads executed by requests on all TiFlash instances is 24 (8 × 3). After `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60 (20 × 3). Before `tidb_max_tiflash_threads` is re-configured: From f189d3c442c079b871b4d4cda0a4b59750d3e496 Mon Sep 17 00:00:00 2001 From: Aolin Date: Wed, 24 Jan 2024 13:03:52 +0800 Subject: [PATCH 4/4] Apply suggestions from code review Co-authored-by: Ran --- tiflash/tune-tiflash-performance.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tiflash/tune-tiflash-performance.md b/tiflash/tune-tiflash-performance.md index 999ab8eee5db2..8c19bf7d96d07 100644 --- a/tiflash/tune-tiflash-performance.md +++ b/tiflash/tune-tiflash-performance.md @@ -305,7 +305,7 @@ The [`tidb_max_tiflash_threads`](/system-variables.md#tidb_max_tiflash_threads-n set @@tidb_max_tiflash_threads = 20; ``` -The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. Since the cluster has a total of 3 TiFlash instances, the total number of threads executed by requests on all TiFlash instances is 24 (8 × 3). After `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60 (20 × 3). +The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. Since the cluster has a total of 3 TiFlash instances, the total number of threads for request execution on all TiFlash instances is 24 (8 × 3). After `tidb_max_tiflash_threads` is set to `20`, the total number of threads for request execution on all TiFlash instances is 60 (20 × 3). Before `tidb_max_tiflash_threads` is re-configured: