From d6e7e80df35516db1baaf088bf6cb564ec913073 Mon Sep 17 00:00:00 2001 From: zkthernum Date: Mon, 1 Jan 2024 19:03:47 +0800 Subject: [PATCH 1/4] add translation --- tiflash/tune-tiflash-performance.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tiflash/tune-tiflash-performance.md b/tiflash/tune-tiflash-performance.md index 6f6493f2ad5ac..09046d41392a0 100644 --- a/tiflash/tune-tiflash-performance.md +++ b/tiflash/tune-tiflash-performance.md @@ -304,7 +304,8 @@ The [`tidb_max_tiflash_threads`](/system-variables.md#tidb_max_tiflash_threads-n set @@tidb_max_tiflash_threads = 20; ``` -The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before the re-configuration, the execution concurrency of all TiFlash operators is 24. After the value of this variable changes to `20`, the concurrency becomes 60. +The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. The cluster has a total of 3 TiFlash instances, so the total number of threads executed by requests on all TiFlash instances is 24. When `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60. + Before `tidb_max_tiflash_threads` is re-configured: From 276e2b13e659c788ded8492a267045691495ec31 Mon Sep 17 00:00:00 2001 From: zkthernum Date: Tue, 9 Jan 2024 18:40:04 +0800 Subject: [PATCH 2/4] add some explanation for tiflash tuning performance doc --- tiflash/tune-tiflash-performance.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tiflash/tune-tiflash-performance.md b/tiflash/tune-tiflash-performance.md index 09046d41392a0..684d77c5dcbba 100644 --- a/tiflash/tune-tiflash-performance.md +++ b/tiflash/tune-tiflash-performance.md @@ -304,8 +304,7 @@ The [`tidb_max_tiflash_threads`](/system-variables.md#tidb_max_tiflash_threads-n set @@tidb_max_tiflash_threads = 20; ``` -The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. The cluster has a total of 3 TiFlash instances, so the total number of threads executed by requests on all TiFlash instances is 24. When `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60. - +The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. The cluster has a total of 3 TiFlash instances, so the total number of threads executed by requests on all TiFlash instances is 24(8 × 3). When `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60(20 × 3). Before `tidb_max_tiflash_threads` is re-configured: From c4176cf7e3165d1c36a415106e8eaee56ea05803 Mon Sep 17 00:00:00 2001 From: Aolin Date: Wed, 24 Jan 2024 10:20:57 +0800 Subject: [PATCH 3/4] Apply suggestions from code review --- tiflash/tune-tiflash-performance.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tiflash/tune-tiflash-performance.md b/tiflash/tune-tiflash-performance.md index 684d77c5dcbba..1410bec256d1c 100644 --- a/tiflash/tune-tiflash-performance.md +++ b/tiflash/tune-tiflash-performance.md @@ -304,7 +304,7 @@ The [`tidb_max_tiflash_threads`](/system-variables.md#tidb_max_tiflash_threads-n set @@tidb_max_tiflash_threads = 20; ``` -The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. The cluster has a total of 3 TiFlash instances, so the total number of threads executed by requests on all TiFlash instances is 24(8 × 3). When `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60(20 × 3). +The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. Since the cluster has a total of 3 TiFlash instances, the total number of threads executed by requests on all TiFlash instances is 24 (8 × 3). After `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60 (20 × 3). Before `tidb_max_tiflash_threads` is re-configured: From e5c166cb418baefbe879519f3f8546f610c2d67a Mon Sep 17 00:00:00 2001 From: Aolin Date: Wed, 24 Jan 2024 13:03:52 +0800 Subject: [PATCH 4/4] Apply suggestions from code review Co-authored-by: Ran --- tiflash/tune-tiflash-performance.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tiflash/tune-tiflash-performance.md b/tiflash/tune-tiflash-performance.md index 1410bec256d1c..4ed62b70d37c8 100644 --- a/tiflash/tune-tiflash-performance.md +++ b/tiflash/tune-tiflash-performance.md @@ -304,7 +304,7 @@ The [`tidb_max_tiflash_threads`](/system-variables.md#tidb_max_tiflash_threads-n set @@tidb_max_tiflash_threads = 20; ``` -The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. Since the cluster has a total of 3 TiFlash instances, the total number of threads executed by requests on all TiFlash instances is 24 (8 × 3). After `tidb_max_tiflash_threads` is set to `20`, the total number of threads executed by requests on all TiFlash instances is 60 (20 × 3). +The following example shows the query result before and after `tidb_max_tiflash_threads` is re-configured. Before `tidb_max_tiflash_threads` is set, the concurrency of request execution for a single TiFlash instance is 8 threads. Since the cluster has a total of 3 TiFlash instances, the total number of threads for request execution on all TiFlash instances is 24 (8 × 3). After `tidb_max_tiflash_threads` is set to `20`, the total number of threads for request execution on all TiFlash instances is 60 (20 × 3). Before `tidb_max_tiflash_threads` is re-configured: