reference/configuration: add description about TiDB txn-total-size-limit #2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
added
size/small
Contributor
Author
jackysp
reviewed
Mar 13, 2020
|
|
||
| - The size limit of a transaction. | ||
| - Default value: `104857600` | ||
| - The total key-value entries size in bytes should be less than this value. Note, if the `binlog` is enabled, this value should be less than 104857600(100M), because of the limitation of the binlog component; If `binlog` is not enabled, the maximum value of this configuration is 10737418240(10G). |
Member
There was a problem hiding this comment.
Should we set a lower limit, if the size is too low, TiDB will not start? This comment may not be related to the documentation.
Contributor
Author
There was a problem hiding this comment.
Not necessary. Our customers are sane enough.
TomShawn
reviewed
Mar 13, 2020
| ### `txn-total-size-limit` | ||
|
|
||
| - The size limit of a transaction. | ||
| - Default value: `104857600` |
Contributor
There was a problem hiding this comment.
What about adding a unit?
Contributor
Author
There was a problem hiding this comment.
In the description, it says "size in bytes" @TomShawn
Contributor
|
@tiancaiamao Please address the above comments, thanks! |
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Contributor
Author
|
PTAL @jackysp |
Contributor
|
cherry pick to release-4.0 in PR #2181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Update configuration-file.go, add description about TiDB txn-total-size-limit
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?
http://github.com/pingcap/tidb/pull/14522