-
Notifications
You must be signed in to change notification settings - Fork 709
how-to/deploy: add TiFlash to TiUP deployment #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yikeke
commented
Apr 9, 2020
yikeke
commented
Apr 9, 2020
…e/docs into add-tiflash-to-tiup-deploy
Contributor
Author
|
PTAL @superlzs0476 |
Contributor
|
LGTM |
superlzs0476
approved these changes
Apr 15, 2020
Contributor
superlzs0476
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lilin90
reviewed
Apr 15, 2020
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
lilin90
reviewed
Apr 15, 2020
Member
lilin90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sre-bot
pushed a commit
to sre-bot/docs
that referenced
this pull request
Apr 15, 2020
* how-to/deploy: add TiFlash to TiUP deployment * Update tiup.md * Update how-to/deploy/orchestrated/tiup.md * Update how-to/deploy/orchestrated/tiup.md * fix links * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #2288 |
yikeke
added a commit
that referenced
this pull request
Apr 15, 2020
* how-to/deploy: add TiFlash to TiUP deployment * Update tiup.md * Update how-to/deploy/orchestrated/tiup.md * Update how-to/deploy/orchestrated/tiup.md * fix links * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Lilian Lee <lilin@pingcap.com> Co-authored-by: Lilian Lee <lilin@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/PTAL
This PR is ready for reviewing.
translation/from-docs-cn
This PR is translated from a PR in pingcap/docs-cn.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
add TiFlash to TiUP deployment doc
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?