Skip to content

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Apr 9, 2020

What is changed, added or deleted? (Required)

add TiFlash to TiUP deployment doc

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@yikeke yikeke requested a review from lilin90 April 9, 2020 16:58
@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Apr 9, 2020
@yikeke
Copy link
Contributor Author

yikeke commented Apr 9, 2020

PTAL @superlzs0476

@yikeke yikeke requested a review from superlzs0476 April 14, 2020 05:59
@yikeke yikeke added the status/PTAL This PR is ready for reviewing. label Apr 14, 2020
@superlzs0476
Copy link
Contributor

LGTM

Copy link
Contributor

@superlzs0476 superlzs0476 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit 3df6235 into pingcap:master Apr 15, 2020
@yikeke yikeke deleted the add-tiflash-to-tiup-deploy branch April 15, 2020 11:24
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 15, 2020
* how-to/deploy: add TiFlash to TiUP deployment

* Update tiup.md

* Update how-to/deploy/orchestrated/tiup.md

* Update how-to/deploy/orchestrated/tiup.md

* fix links

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

Co-authored-by: Lilian Lee <lilin@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

cherry pick to release-4.0 in PR #2288

yikeke added a commit that referenced this pull request Apr 15, 2020
* how-to/deploy: add TiFlash to TiUP deployment

* Update tiup.md

* Update how-to/deploy/orchestrated/tiup.md

* Update how-to/deploy/orchestrated/tiup.md

* fix links

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants