TiUP: fix grammar and format for topology.example.yaml #2360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toutdesuite
added
needs-cherry-pick-4.0
translation/from-docs-cn
yikeke
reviewed
Apr 21, 2020
how-to/deploy/orchestrated/tiup.md
Outdated
| # # Global variables are applied to all deployments and as the default value of | ||
| # # them if the specific deployment value missing. | ||
| # # Global variables are applied to all deployments and used as the default value of | ||
| # # The deployments if a specific deployment value is missing. |
Contributor
There was a problem hiding this comment.
Suggested change
| # # The deployments if a specific deployment value is missing. | |
| # # the deployments if a specific deployment value is missing. |
Please see my commits and comment in pingcap/docs-cn#2846 and align them in this PR. Thanks!
yikeke
reviewed
Apr 21, 2020
how-to/deploy/orchestrated/tiup.md
Outdated
| # log_dir: "/tidb-deploy/pump-8249/log" | ||
| # numa_node: "0,1" | ||
| # # Config is used to overwrite the `server_configs.drainer` values | ||
| # # The following configs are used to overwrite the `server_configs.pd` values. |
Contributor
There was a problem hiding this comment.
Suggested change
| # # The following configs are used to overwrite the `server_configs.pd` values. | |
| # # The following configs are used to overwrite the `server_configs.drainer` values. |
yikeke
reviewed
Apr 21, 2020
how-to/deploy/orchestrated/tiup.md
Outdated
| # log_dir: "/tidb-deploy/drainer-8249/log" | ||
| # numa_node: "0,1" | ||
| # # Config is used to overwrite the `server_configs.drainer` values | ||
| # # The following configs are used to overwrite the `server_configs.pd` values. |
Contributor
There was a problem hiding this comment.
Suggested change
| # # The following configs are used to overwrite the `server_configs.pd` values. | |
| # # The following configs are used to overwrite the `server_configs.drainer` values. |
yikeke
reviewed
Apr 21, 2020
how-to/deploy/orchestrated/tiup.md
Outdated
| deploy_dir: "/tidb-deploy/pump-8249" | ||
| data_dir: "/tidb-data/pump-8249" | ||
| # Config is used to overwrite the `server_configs.drainer` values | ||
| # The following configs are used to overwrite the `server_configs.pd` values. |
how-to/deploy/orchestrated/tiup.md
Outdated
| deploy_dir: "/tidb-deploy/pump-8249" | ||
| data_dir: "/tidb-data/pump-8249" | ||
| # Config is used to overwrite the `server_configs.drainer` values | ||
| # The following configs are used to overwrite the `server_configs.pd` values. |
how-to/deploy/orchestrated/tiup.md
Outdated
| deploy_dir: "/tidb-deploy/pump-8249" | ||
| data_dir: "/tidb-data/pump-8249" | ||
| # Config is used to overwrite the `server_configs.drainer` values | ||
| # The following configs are used to overwrite the `server_configs.pd` values. |
how-to/deploy/orchestrated/tiup.md
Outdated
| commit_ts: -1 | ||
| deploy_dir: "/tidb-deploy/drainer-8249" | ||
| # Config is used to overwrite the `server_configs.drainer` values | ||
| # The following configs are used to overwrite the `server_configs.pd` values. |
how-to/deploy/orchestrated/tiup.md
Outdated
| log_dir: "deploy/tidb-4000/log" | ||
| numa_node: "0,1" | ||
| # Config is used to overwrite the `server_configs.tidb` values | ||
| # The following configs are used to overwrite the `server_configs.pd` values. |
sre-bot
pushed a commit
to sre-bot/docs
that referenced
this pull request
Apr 21, 2020
* Fix grammar and format for topology.example.yaml * address comments * Update tiup.md * Update tiup.md * Update tiup.md * Update tiup.md * Update tiup.md * Update tiup.md * Update quick-start-with-tidb.md
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #2361 |
yikeke
pushed a commit
that referenced
this pull request
Apr 21, 2020
* Fix grammar and format for topology.example.yaml * address comments * Update tiup.md * Update tiup.md * Update tiup.md * Update tiup.md * Update tiup.md * Update tiup.md * Update quick-start-with-tidb.md Co-authored-by: toutdesuite <guizhiluo2014@163.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
TiUP: fix grammar and format for topology.example.yaml
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?