Skip to content

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jun 1, 2020

What is changed, added or deleted? (Required)

Update the doc for deploying TiDB cluster using TiUP.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Jun 1, 2020
@ran-huang ran-huang requested review from superlzs0476 and yikeke June 1, 2020 10:19
@yikeke
Copy link
Contributor

yikeke commented Jun 5, 2020

Except for the deadlinks, rest LGTM. You can take a look at my commits and see if there are any problems. @ran-huang

@yikeke yikeke added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 5, 2020
@ran-huang
Copy link
Contributor Author

@yikeke Made a minor edit. Rest LGTM.

@yikeke
Copy link
Contributor

yikeke commented Jun 5, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 5, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

@ran-huang merge failed.

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit 0af51fd into pingcap:master Jun 5, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 5, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

cherry pick to release-4.0 in PR #2717

yikeke pushed a commit that referenced this pull request Jun 5, 2020
* cherry pick #2649 to release-4.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* change version of template files

Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang deleted the tiup-deployment branch July 30, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants