Skip to content

Conversation

@toutdesuite
Copy link
Contributor

@toutdesuite toutdesuite commented Jun 3, 2020

What is changed, added or deleted? (Required)

Update backup-and-restore-tool.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@toutdesuite toutdesuite requested review from TomShawn and yikeke June 3, 2020 07:40
@toutdesuite toutdesuite added needs-cherry-pick-3.1 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 3, 2020
@toutdesuite
Copy link
Contributor Author

@YuJuncen PTAL, thanks
You made the following change in the restore section of br/backup-and-restore-tool.md in https://github.com/pingcap/docs-cn/pull/3143/files
image
Please double check whether the same change need to be made in the backup section
Since I cannot request your review, I leave a comment here to make sure that you will receive the email~

@yikeke yikeke requested review from ran-huang and removed request for TomShawn June 3, 2020 09:31
@yikeke
Copy link
Contributor

yikeke commented Jun 3, 2020

Please help review this PR, thanks~ @ran-huang

@YuJuncen
Copy link
Contributor

YuJuncen commented Jun 3, 2020

@YuJuncen PTAL, thanks
You made the following change in the restore section of br/backup-and-restore-tool.md in https://github.com/pingcap/docs-cn/pull/3143/files
image
Please double check whether the same change need to be made in the backup section
Since I cannot request your review, I leave a comment here to make sure that you will receive the email~

This flag(in fact, all boolean flags), should be used by the form --boolean-flag(make this flag be true) or --boolean-flag=true(make the flag be specified value). --boolean-flag <ture|false> is a misuse and will always make this flag be true.

Either make this flag be --boolean-flag or --boolean-flag=true would be OK, and the original version also works(even it isn't 'right' enough and misleading, because --boolean-flag false will make the flag be true), so change this at backup section too if possible, thanks.

@toutdesuite
Copy link
Contributor Author

@YuJuncen PTAL, thanks
You made the following change in the restore section of br/backup-and-restore-tool.md in https://github.com/pingcap/docs-cn/pull/3143/files
image
Please double check whether the same change need to be made in the backup section
Since I cannot request your review, I leave a comment here to make sure that you will receive the email~

This flag(in fact, all boolean flags), should be used by the form --boolean-flag(make this flag be true) or --boolean-flag=true(make the flag be specified value). --boolean-flag <ture|false> is a misuse and will always make this flag be true.

Either make this flag be --boolean-flag or --boolean-flag=true would be OK, and the original version also works(even it isn't 'right' enough and misleading, because --boolean-flag false will make the flag be true), so change this at backup section too if possible, thanks.

Thanks for your detailed explanation. --send-credentials-to-tikv true has been modified in this PR. I' ll update it in the Chinese doc later

Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor edits~

toutdesuite and others added 14 commits June 5, 2020 15:10
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
toutdesuite and others added 4 commits June 5, 2020 22:44
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
@yikeke yikeke removed their request for review June 8, 2020 02:42
toutdesuite and others added 2 commits June 8, 2020 12:15
Co-authored-by: Ran <huangran@pingcap.com>
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
@toutdesuite toutdesuite added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

/run-all-tests

@toutdesuite toutdesuite merged commit 9659fb8 into pingcap:master Jun 8, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-3.1 in PR #2722

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-4.0 in PR #2723

toutdesuite added a commit that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: toutdesuite <guizhiluo2014@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants