Skip to content

Conversation

@sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 4, 2020

cherry-pick #2656 to release-4.0


What is changed, added or deleted? (Required)

Add check-before-deployment.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot added the type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. label Jun 4, 2020
@sre-bot sre-bot requested review from superlzs0476 and yikeke June 4, 2020 09:28
<<<<<<< HEAD
Log in to the Control Machine using the `tidb` user account and enter the `/home/tidb` directory. Run the following command to download the [TAG version](https://github.com/pingcap/tidb-ansible/tags) corresponding to TiDB Ansible 4.0 from the [TiDB Ansible project](https://github.com/pingcap/tidb-ansible). The default folder name is `tidb-ansible`.
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check globally to make sure all conflicts are resolved. @ran-huang

@ran-huang
Copy link
Contributor

ran-huang commented Jun 4, 2020

@yikeke Conflicts resolved. PTAL.

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@ran-huang ran-huang merged commit ab1c3e5 into pingcap:release-4.0 Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants