Skip to content

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jun 4, 2020

What is changed, added or deleted? (Required)

Add Dashboard diagnostics docs.

This PR must be merged after #2655.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Jun 4, 2020
@TomShawn TomShawn marked this pull request as ready for review June 5, 2020 09:09
@TomShawn TomShawn requested review from crazycs520 and yikeke June 5, 2020 09:09
@yikeke yikeke requested review from toutdesuite and removed request for yikeke June 8, 2020 07:28
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn mentioned this pull request Jun 8, 2020
5 tasks
category: how-to
---

# TiDB Dashboard Cluster Diagnostics Page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TiDB Dashboard Cluster Diagnostics Page
# TiDB Dashboard Cluster Diagnostic Page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in the actual UI, we can see Cluster Diagnostics.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diagnostics is correct @toutdesuite


#### Report Time Range

The time range for generating the report includes the start time and end time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

TomShawn and others added 2 commits June 9, 2020 14:30
Co-authored-by: toutdesuite <guizhiluo2014@163.com>
Co-authored-by: crazycs <crazycs520@gmail.com>
@TomShawn
Copy link
Contributor Author

TomShawn commented Jun 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2020
@TomShawn TomShawn merged commit 7546228 into pingcap:master Jun 9, 2020
@TomShawn
Copy link
Contributor Author

TomShawn commented Jun 9, 2020

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2020

/run-all-tests

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 9, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2020

cherry pick to release-4.0 in PR #2756

@TomShawn TomShawn deleted the dashboard-diagnostics branch June 9, 2020 12:00
TomShawn added a commit that referenced this pull request Jun 9, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@sre-bot sre-bot mentioned this pull request Jun 9, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants