Update Key Visualizer doc #2698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomShawn
added
translation/from-docs-cn
TomShawn
commented
Jun 5, 2020
Contributor
|
Please help review this PR, thanks~ @CaitinChen |
CaitinChen
reviewed
Jun 8, 2020
Co-authored-by: Caitin <34535727+CaitinChen@users.noreply.github.com>
HunDunDM
reviewed
Jun 9, 2020
Contributor
HunDunDM
left a comment
HunDunDM
left a comment
There was a problem hiding this comment.
Need to use dashboard-key-visualizer.md instead of key-visualizer-monitoring-tool.md to keep the file name unified with docs-cn?
Comment on lines
22
to
24
| > **Note:** | ||
| > | ||
| > + If multiple PD instances exist, you can use any PD instance address to access TiDB Dashboard. | ||
| > + By default, `PDPort` is `2379`. If you have modified the corresponding PD parameter during deployment, use the modified PD port. | ||
| > + You need to use the `root` account of TiDB to log into TiDB Dashboard. | ||
| > The Key Visualizer feature is disabled by default. If you use this feature for the first time, You need to manually enable it. To enable this feature, follow the interface guide or see the [Settings](#settings) section of this document. |
Contributor
There was a problem hiding this comment.
This feature is currently enabled by default, please delete this part.
| ### Evenly distributed workload | ||
|
|
||
|  | ||
|  |
Contributor
There was a problem hiding this comment.
Suggested change
|  | |
|  |
Contributor
Author
|
@HunDunDM Comment addressed, PTAL again, thanks! |
TomShawn
added
status/can-merge
Contributor
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/docs
that referenced
this pull request
Jun 9, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #2740 |
sre-bot
added a commit
that referenced
this pull request
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Update Key Visualizer doc.
This PR must be merged after #2655.
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?