Skip to content

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 5, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Jun 5, 2020
@yikeke yikeke added needs-cherry-pick-3.1 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed contribution This PR is from a community contributor. labels Jun 5, 2020
@yikeke yikeke marked this pull request as ready for review June 5, 2020 09:49
@yikeke yikeke requested a review from lilin90 June 5, 2020 09:56
@yikeke
Copy link
Contributor Author

yikeke commented Jun 5, 2020

PTAL @YuJuncen

Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

yikeke and others added 2 commits June 8, 2020 13:47
Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
@yikeke
Copy link
Contributor Author

yikeke commented Jun 9, 2020

PTAL @lilin90

yikeke and others added 2 commits June 10, 2020 11:01
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit dcb4bb2 into pingcap:master Jun 10, 2020
@yikeke yikeke deleted the add-dumpling-doc branch June 10, 2020 03:16
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

cherry pick to release-2.1 in PR #2760

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

cherry pick to release-3.0 in PR #2761

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

cherry pick to release-3.1 in PR #2762

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

cherry pick to release-4.0 in PR #2763

yikeke added a commit that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
sre-bot added a commit that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
sre-bot added a commit that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
sre-bot added a commit that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants