Skip to content

Conversation

@overvenus
Copy link
Member

@overvenus overvenus commented Jun 10, 2020

What is changed, added or deleted? (Required)

Update BR --version flag.
To close #2754.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus requested review from 3pointer and TomShawn June 10, 2020 06:31
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@TomShawn TomShawn added needs-cherry-pick-3.1 translation/doing This PR's assignee is translating this PR. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. and removed translation/doing This PR's assignee is translating this PR. labels Jun 10, 2020
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit f95277a into master Jun 10, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 10, 2020
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

cherry pick to release-3.1 in PR #2768

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 10, 2020
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

cherry pick to release-4.0 in PR #2769

TomShawn pushed a commit that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Neil Shen <overvenus@gmail.com>
TomShawn added a commit that referenced this pull request Jun 16, 2020
* cherry pick #2765 to release-3.1

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* br: fix confliction

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: Neil Shen <overvenus@gmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@yikeke yikeke deleted the br/version branch June 16, 2020 04:42
@yikeke yikeke added size/small Changes of a small size. translation/doing This PR's assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 7, 2020
@ireneontheway ireneontheway added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changed: br Sub command "version" is now an option --version

7 participants