Skip to content

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 17, 2020

What is changed, added or deleted? (Required)

Add syntax gram of load stats.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@qw4990 qw4990 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-3.0 labels Jun 17, 2020
@CLAassistant
Copy link

CLAassistant commented Jun 17, 2020

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot requested a review from yikeke June 17, 2020 05:39
@qw4990 qw4990 requested a review from djshow832 June 17, 2020 05:39
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 17, 2020
@yikeke
Copy link
Contributor

yikeke commented Jun 17, 2020

This PR is aligned from pingcap/docs-cn#3362? If so, you also need to add the needs-cherry-pick-2.1 label. @qw4990

@yikeke yikeke removed the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jun 17, 2020
qw4990 and others added 5 commits June 18, 2020 14:19
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 18, 2020

All comments have been addressed, PTAL @yikeke

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Jun 18, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

/run-all-tests

@yikeke yikeke merged commit b246ebe into master Jun 18, 2020
@yikeke yikeke deleted the load-stats branch June 18, 2020 07:38
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 18, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #2954

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 18, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #2955

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 18, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #2956

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 18, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2957

yikeke pushed a commit that referenced this pull request Jun 18, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Yuanjia Zhang <zhangyuanjia@pingcap.com>
yikeke pushed a commit that referenced this pull request Jun 18, 2020
* cherry pick #2926 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update TOC.md

* update'
”

Co-authored-by: Yuanjia Zhang <zhangyuanjia@pingcap.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
yikeke pushed a commit that referenced this pull request Jun 18, 2020
* cherry pick #2926 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update TOC.md

* update

Co-authored-by: Yuanjia Zhang <zhangyuanjia@pingcap.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
yikeke pushed a commit that referenced this pull request Jun 18, 2020
* cherry pick #2926 to release-2.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update TOC.md

* update

Co-authored-by: Yuanjia Zhang <zhangyuanjia@pingcap.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants