Skip to content

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jun 18, 2020

What is changed, added or deleted? (Required)

Add doc for store limit.

Note: Each branch is slightly different from other branches. Please modify them after cherry-picking.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang requested review from rleungx and yikeke June 18, 2020 03:37
@ran-huang ran-huang added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 18, 2020
@yikeke yikeke requested review from lilin90 and removed request for yikeke June 19, 2020 03:57
@ti-srebot
Copy link
Contributor

@lilin90, @rleungx, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@lilin90, @rleungx, PTAL.

@ti-srebot
Copy link
Contributor

@lilin90, @rleungx, PTAL.

@lilin90 lilin90 added the size/medium Changes of a medium size. label Jun 30, 2020

# Store Limit

Store Limit is a feature of PD, introduced in TiDB 4.0. It is designed to control the scheduling speed in a finer manner for better performance in different scenarios.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the Chinese doc says this feature was introduced in 3.0. Please help confirm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirmed with the author. This is a 3.0 feature, but we don't have the relevant docs for v3.0 and v3.1 yet, which are slightly different from the dev version.
He'll create a PR to add them.

@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Jun 30, 2020
ran-huang and others added 2 commits June 30, 2020 17:28
@ran-huang ran-huang added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. and removed status/require-change Needs the author to address comments. labels Jun 30, 2020
@ran-huang
Copy link
Contributor Author

@lilin90 PTAL again. Thanks~

@ran-huang ran-huang added the status/WIP This PR is still working in progress. label Jun 30, 2020
@ran-huang ran-huang removed the status/WIP This PR is still working in progress. label Jun 30, 2020
@ran-huang
Copy link
Contributor Author

The changes in pingcap/docs-cn#3831 has been aligned in this commit 2d8c671.

ran-huang and others added 2 commits July 1, 2020 14:24
@ran-huang
Copy link
Contributor Author

@lilin90 @rleungx All comments addressed. PTAL again. Thanks~

@ran-huang ran-huang requested review from lilin90 and rleungx July 1, 2020 07:40
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member

lilin90 commented Jul 2, 2020

/merge

@ti-srebot
Copy link
Contributor

Sorry @lilin90, you don't have permission to trigger auto merge event on this branch. The number of LGTM for this PR is 0 while it need 2

@lilin90 lilin90 added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 2, 2020
@lilin90 lilin90 merged commit 23e53ef into pingcap:master Jul 2, 2020
@ran-huang ran-huang deleted the store-limit branch July 2, 2020 06:45
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3111

@ran-huang
Copy link
Contributor Author

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3112

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3113

ran-huang added a commit that referenced this pull request Jul 3, 2020
* cherry pick #2947 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* align with pingcap/docs-cn#3832

Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request Jul 3, 2020
* cherry pick #2947 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict

* update 3.1 specific changes

Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request Jul 3, 2020
* cherry pick #2947 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict

* update 3.0 specific changes

Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/medium Changes of a medium size. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants