Skip to content

Add three-DC-in-two-cities deployment #2963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 2, 2020
Merged

Add three-DC-in-two-cities deployment #2963

merged 8 commits into from
Jul 2, 2020

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jun 18, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Add three-DC-in-two-cities deployment doc.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 special-week PR from Document Special Week. labels Jun 18, 2020
@TomShawn TomShawn requested review from freyfl and yikeke June 18, 2020 13:51
@TomShawn TomShawn marked this pull request as draft June 18, 2020 13:51
@TomShawn TomShawn removed request for freyfl and yikeke June 18, 2020 13:51
@TomShawn TomShawn marked this pull request as ready for review June 19, 2020 04:53
@TomShawn TomShawn requested review from freyfl and yikeke June 19, 2020 04:53
TomShawn
TomShawn commented Jun 19, 2020
View reviewed changes
@yikeke yikeke requested review from lilin90 and removed request for yikeke June 19, 2020 06:26
@lilin90 lilin90 added the size/large Changes of a large size. label Jun 30, 2020
@lilin90 lilin90 mentioned this pull request Jun 30, 2020
Merged
5 tasks
lilin90
lilin90 reviewed Jun 30, 2020
View reviewed changes
@lilin90 lilin90 added status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. labels Jun 30, 2020
@lilin90
Copy link
Member

lilin90 commented Jun 30, 2020

@freyfl PTAL

lilin90
lilin90 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 10b0810 into pingcap:master Jul 2, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 2, 2020
@TomShawn @ti-srebot
cherry pick pingcap#2963 to release-4.0
b8de5cf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 2, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 2, 2020

cherry pick to release-4.0 in PR #3109

lilin90 pushed a commit that referenced this pull request Jul 2, 2020
@ti-srebot @TomShawn
cherry pick #2963 to release-4.0 (#3109)
efe5156 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn deleted the 2city-3dcdeploy branch July 2, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@freyfl freyfl Awaiting requested review from freyfl

Assignees

No one assigned

Labels

size/large Changes of a large size. special-week PR from Document Special Week. status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomShawn @lilin90 @ti-srebot