Skip to content

Update use-tiflash.md from Special Week changes #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 28, 2020
Merged

Update use-tiflash.md from Special Week changes #2972

merged 9 commits into from
Jun 28, 2020

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 19, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:

pingcap/docs-cn#3351
pingcap/docs-cn#3396
pingcap/docs-cn#3687

  • Other reference link(s):

@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 19, 2020
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 19, 2020
@yikeke yikeke removed the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jun 19, 2020
@yikeke yikeke marked this pull request as ready for review June 23, 2020 10:05
@yikeke yikeke requested review from TomShawn and zanmato1984 June 23, 2020 10:06
@yikeke yikeke changed the title Update use-tiflash.md Update use-tiflash.md from Special Week changes Jun 23, 2020
TomShawn
TomShawn reviewed Jun 24, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM
@zanmato1984 PTAL

@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 26, 2020

@TomShawn, @zanmato1984, PTAL.

@TomShawn TomShawn added status/require-change Needs the author to address comments. status/PTAL This PR is ready for reviewing. and removed status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. labels Jun 27, 2020
yikeke and others added 2 commits June 28, 2020 10:20
@yikeke @TomShawn
Apply suggestions from code review
eb2c6e6 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@yikeke
Merge branch 'master' into use-tiflash-update
227caf3
@yikeke
Copy link
Contributor Author

yikeke commented Jun 28, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 28, 2020

Your auto merge job has been accepted, waiting for:

  • 3005

@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 28, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 8cadd05 into master Jun 28, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 28, 2020
@yikeke @ti-srebot
cherry pick pingcap#2972 to release-4.0
6472d4a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 28, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 28, 2020

cherry pick to release-4.0 in PR #3045

@yikeke yikeke deleted the use-tiflash-update branch June 28, 2020 02:54
ti-srebot added a commit that referenced this pull request Jun 28, 2020
@ti-srebot
Update use-tiflash.md from Special Week changes (#2972) (#3045)
9f0aeda 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yikeke @ti-srebot @TomShawn